From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Vipin Varghese <vipin.varghese@intel.com>,
olivier.matz@6wind.com, reshma.pattan@intel.com,
keith.wiles@intel.com, dev@dpdk.org, sanjay.padubidri@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck
Date: Fri, 7 Jun 2019 10:30:42 +0100 [thread overview]
Message-ID: <20190607093042.GB1600@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190606124927.1a369d5b@hermes.lan>
On Thu, Jun 06, 2019 at 12:49:27PM -0700, Stephen Hemminger wrote:
> On Fri, 7 Jun 2019 00:03:54 +0530
> Vipin Varghese <vipin.varghese@intel.com> wrote:
>
> > Add callback event handler for enqueue dequeue operation on ring.
> > The pre-enqueue and post-dequeue operation on ring is selected to
> > invoke user callback handler.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
>
> NAK
> What is the use case for this? Rings are one of the most used elements
> of DPDK and anything like this will have performance impact.
>
> And as DPDK goes to more of distribution model, all features have to be
> enabled.
>
To add callback handlers to a ring, I'd suggest wrapping the ring as an
ethdev using the ring pmd, and then using the ethdev callbacks.
/Bruce
next prev parent reply other threads:[~2019-06-07 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 18:33 Vipin Varghese
2019-06-06 18:33 ` [dpdk-dev] [PATCH v1 2/2] examples/packet_ordering: add ring callback Vipin Varghese
2019-06-06 19:49 ` [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck Stephen Hemminger
2019-06-07 9:30 ` Bruce Richardson [this message]
2019-06-10 5:14 ` Varghese, Vipin
2019-06-07 10:45 ` Ananyev, Konstantin
2019-06-10 5:16 ` Varghese, Vipin
2019-06-10 5:07 ` Varghese, Vipin
2019-06-07 6:03 ` Honnappa Nagarahalli
2019-06-10 5:12 ` Varghese, Vipin
2019-06-11 4:17 ` Honnappa Nagarahalli
2019-07-04 5:04 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607093042.GB1600@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=olivier.matz@6wind.com \
--cc=reshma.pattan@intel.com \
--cc=sanjay.padubidri@intel.com \
--cc=stephen@networkplumber.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).