From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice about changes to ethernet structures
Date: Fri, 19 Jul 2019 11:57:16 +0100 [thread overview]
Message-ID: <20190719105716.GA1647@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190718220910.8248-1-stephen@networkplumber.org>
On Thu, Jul 18, 2019 at 03:09:10PM -0700, Stephen Hemminger wrote:
> Tell users about upcoming changes to rte_ether_addr and
> rte_ether_header.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> doc/guides/rel_notes/deprecation.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index a7796f49b9fe..9c20a47b3e4c 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -82,3 +82,12 @@ Deprecation Notices
> to set new power environment if power environment was already initialized.
> In this case the function will return -1 unless the environment is unset first
> (using ``rte_power_unset_env``). Other function usage scenarios will not change.
> +
> +* net: the Ethernet address and header defintions will change attributes.
> + The Ethernet address struct will no longer be marked as packed since
> + since the packed attribute is meaningless on a byte array.
> + The Etherne header will be marked as aligned on a 2 byte boundary (and
> + no longer packed). This allows for efficient access on all CPU's.
> + These changes should not impact normal usage drivers naturally
> + align the Ethernet header on receive, and almost every encapsulation
> + preserves the alignment.
> --
> 2.17.1
More comprehensive deprecation notice than mine, so:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
One suggested change, rather than "almost every encapsulation" can we put
it down as "all known encapsulations". If there is even a single public
spec, in-real-use encapsulation that is used that does not preserve
alignment, we should not do this. Saying "almost every" implies that we
know of ones that don't, which I don't believe is the case.
/Bruce
next prev parent reply other threads:[~2019-07-19 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 14:58 [dpdk-dev] [PATCH] doc: deprecation notice for change of ether struct alignment Bruce Richardson
2019-07-09 14:59 ` Stephen Hemminger
2019-07-09 15:02 ` Bruce Richardson
2019-07-18 22:09 ` [dpdk-dev] [PATCH] doc: add deprecation notice about changes to ethernet structures Stephen Hemminger
2019-07-19 10:57 ` Bruce Richardson [this message]
2019-07-19 16:56 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-07-23 11:28 ` Andrew Rybchenko
2019-07-31 10:46 ` Ferruh Yigit
2019-08-06 11:26 ` Thomas Monjalon
2019-08-10 20:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719105716.GA1647@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).