DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token
Date: Tue, 22 Oct 2019 16:43:09 +0100	[thread overview]
Message-ID: <20191022154310.41238-9-bruce.richardson@intel.com> (raw)
In-Reply-To: <20191022154310.41238-1-bruce.richardson@intel.com>

Building the example with clang gives the error:

  error: expression which evaluates to zero treated as a null pointer
  constant of type 'const char *' [-Werror,-Wnon-literal-null-conversion]
                        lcore_id, UINT8);
                                  ^~~~~

This error is due to the wrong data type being given for the
cmd_set_cpu_freq_core_num value - it was specified as string rather than
numeric type.

Fixes: f5e5c3347ae3 ("examples/vm_power: cli in guest")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index fe09b0778..610d9aeac 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -171,7 +171,7 @@ cmd_set_cpu_freq_parsed(void *parsed_result, struct cmdline *cl,
 cmdline_parse_token_string_t cmd_set_cpu_freq =
 	TOKEN_STRING_INITIALIZER(struct cmd_set_cpu_freq_result,
 			set_cpu_freq, "set_cpu_freq");
-cmdline_parse_token_string_t cmd_set_cpu_freq_core_num =
+cmdline_parse_token_num_t cmd_set_cpu_freq_core_num =
 	TOKEN_NUM_INITIALIZER(struct cmd_set_cpu_freq_result,
 			lcore_id, UINT8);
 cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
-- 
2.21.0


  parent reply	other threads:[~2019-10-22 15:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 11:34 [dpdk-dev] [PATCH 0/8] support all examples in a meson build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 1/8] examples/bpf: remove from list of examples to build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 2/8] examples/ethtool: allow building as part of meson build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 3/8] examples/performance-thread: remove warning disabling Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 4/8] examples/performance-thread: rename directory to standard Bruce Richardson
2019-10-14 16:16   ` Jerin Jacob
2019-10-14 16:41     ` Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 5/8] examples/performance-thread: add l3fwd-thread to meson Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 6/8] examples/performance-thread: add pthread shim " Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 7/8] examples/server_node_efd: add node binary to meson build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 8/8] examples/server_node_efd: add server " Bruce Richardson
2019-10-15 13:35 ` [dpdk-dev] [PATCH v2 0/7] support all examples in a " Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 1/7] examples/bpf: remove from list of examples to build Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 2/7] examples/ethtool: allow building as part of meson build Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 3/7] examples/performance-thread: remove warning disabling Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 4/7] examples/performance-thread: add l3fwd-thread to meson Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 5/7] examples/performance-thread: add pthread shim " Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 6/7] examples/server_node_efd: add node binary to meson build Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 7/7] examples/server_node_efd: add server " Bruce Richardson
2019-10-16 11:47   ` [dpdk-dev] [PATCH v2 0/7] support all examples in a " Luca Boccassi
2019-10-22 15:43 ` [dpdk-dev] [PATCH v3 0/9] " Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 1/9] examples/bpf: remove from list of examples to build Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 2/9] examples/ethtool: allow building as part of meson build Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 3/9] examples/performance-thread: remove warning disabling Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 4/9] examples/performance-thread: add l3fwd-thread to meson Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 5/9] examples/performance-thread: add pthread shim " Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 6/9] examples/server_node_efd: add node binary to meson build Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 7/9] examples/server_node_efd: add server " Bruce Richardson
2019-10-22 15:43   ` Bruce Richardson [this message]
2019-10-23 10:40     ` [dpdk-dev] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token Hunt, David
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 9/9] examples/guest_cli: add power manager guest cli to meson Bruce Richardson
2019-10-23 10:38     ` Hunt, David
2019-10-27 16:28   ` [dpdk-dev] [PATCH v3 0/9] support all examples in a meson build Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191022154310.41238-9-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).