DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/8] examples/performance-thread: rename directory to standard
Date: Mon, 14 Oct 2019 21:46:50 +0530	[thread overview]
Message-ID: <CALBAE1NSrXXqpwqzQmEa2oDT61jXn1w0GagCZSuY5Q6N0KzX6w@mail.gmail.com> (raw)
In-Reply-To: <20191014113448.7442-5-bruce.richardson@intel.com>

On Mon, Oct 14, 2019 at 5:05 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> In other places in DPDK, e.g. EAL, the architecture-specific files for arm
> are just stored in a folder called "arm". Rename the "arm64" folder for
> performance thread example to align to this naming.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  examples/performance-thread/common/arch/{arm64 => arm}/ctx.c   | 0
>  examples/performance-thread/common/arch/{arm64 => arm}/ctx.h   | 0
>  examples/performance-thread/common/arch/{arm64 => arm}/stack.h | 0
>  examples/performance-thread/common/common.mk                   | 2 +-
>  4 files changed, 1 insertion(+), 1 deletion(-)
>  rename examples/performance-thread/common/arch/{arm64 => arm}/ctx.c (100%)

This code only works for arm64 as it is storing and restoring arm64 registers.
armv7 registers are different so this code does not work for the generic arm.

arm64 specific code, we always named as arm64

F: lib/librte_hash/rte*_arm64.h
F: lib/librte_efd/rte*_arm64.h
F: lib/librte_table/rte*_arm64.h

IMO, If armv7 support adds in future then we can change the directory
as arch/arm
and have ctx_64.c and ctx_32.c etc. I think, for now, technically it
is correct to call the directory as arm64

  reply	other threads:[~2019-10-14 16:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 11:34 [dpdk-dev] [PATCH 0/8] support all examples in a meson build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 1/8] examples/bpf: remove from list of examples to build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 2/8] examples/ethtool: allow building as part of meson build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 3/8] examples/performance-thread: remove warning disabling Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 4/8] examples/performance-thread: rename directory to standard Bruce Richardson
2019-10-14 16:16   ` Jerin Jacob [this message]
2019-10-14 16:41     ` Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 5/8] examples/performance-thread: add l3fwd-thread to meson Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 6/8] examples/performance-thread: add pthread shim " Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 7/8] examples/server_node_efd: add node binary to meson build Bruce Richardson
2019-10-14 11:34 ` [dpdk-dev] [PATCH 8/8] examples/server_node_efd: add server " Bruce Richardson
2019-10-15 13:35 ` [dpdk-dev] [PATCH v2 0/7] support all examples in a " Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 1/7] examples/bpf: remove from list of examples to build Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 2/7] examples/ethtool: allow building as part of meson build Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 3/7] examples/performance-thread: remove warning disabling Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 4/7] examples/performance-thread: add l3fwd-thread to meson Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 5/7] examples/performance-thread: add pthread shim " Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 6/7] examples/server_node_efd: add node binary to meson build Bruce Richardson
2019-10-15 13:35   ` [dpdk-dev] [PATCH v2 7/7] examples/server_node_efd: add server " Bruce Richardson
2019-10-16 11:47   ` [dpdk-dev] [PATCH v2 0/7] support all examples in a " Luca Boccassi
2019-10-22 15:43 ` [dpdk-dev] [PATCH v3 0/9] " Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 1/9] examples/bpf: remove from list of examples to build Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 2/9] examples/ethtool: allow building as part of meson build Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 3/9] examples/performance-thread: remove warning disabling Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 4/9] examples/performance-thread: add l3fwd-thread to meson Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 5/9] examples/performance-thread: add pthread shim " Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 6/9] examples/server_node_efd: add node binary to meson build Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 7/9] examples/server_node_efd: add server " Bruce Richardson
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token Bruce Richardson
2019-10-23 10:40     ` Hunt, David
2019-10-22 15:43   ` [dpdk-dev] [PATCH v3 9/9] examples/guest_cli: add power manager guest cli to meson Bruce Richardson
2019-10-23 10:38     ` Hunt, David
2019-10-27 16:28   ` [dpdk-dev] [PATCH v3 0/9] support all examples in a meson build Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1NSrXXqpwqzQmEa2oDT61jXn1w0GagCZSuY5Q6N0KzX6w@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).