From: Haiyue Wang <haiyue.wang@intel.com>
To: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com,
ferruh.yigit@intel.com, jerinjacobk@gmail.com,
xiaolong.ye@intel.com, ray.kinsella@intel.com,
chenmin.sun@intel.com
Cc: Haiyue Wang <haiyue.wang@intel.com>
Subject: [dpdk-dev] [PATCH v1 2/3] net/i40e: remove the specific burst mode bit set
Date: Fri, 1 Nov 2019 01:11:38 +0800 [thread overview]
Message-ID: <20191031171139.105110-2-haiyue.wang@intel.com> (raw)
In-Reply-To: <20191031171139.105110-1-haiyue.wang@intel.com>
Just keep the vectorization related burst mode bit set, others are not
so generic.
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 37 +++++++++++++-----------------------
1 file changed, 13 insertions(+), 24 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 6a66cec20..9a2d0045c 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -3024,34 +3024,24 @@ i40e_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,
eth_rx_burst_t pkt_burst = dev->rx_pkt_burst;
uint64_t options;
- if (pkt_burst == i40e_recv_scattered_pkts)
- options = RTE_ETH_BURST_SCALAR | RTE_ETH_BURST_SCATTERED;
- else if (pkt_burst == i40e_recv_pkts_bulk_alloc)
- options = RTE_ETH_BURST_SCALAR | RTE_ETH_BURST_BULK_ALLOC;
- else if (pkt_burst == i40e_recv_pkts)
+ if (pkt_burst == i40e_recv_scattered_pkts ||
+ pkt_burst == i40e_recv_pkts_bulk_alloc ||
+ pkt_burst == i40e_recv_pkts)
options = RTE_ETH_BURST_SCALAR;
#ifdef RTE_ARCH_X86
- else if (pkt_burst == i40e_recv_scattered_pkts_vec_avx2)
- options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_AVX2 |
- RTE_ETH_BURST_SCATTERED;
- else if (pkt_burst == i40e_recv_pkts_vec_avx2)
+ else if (pkt_burst == i40e_recv_scattered_pkts_vec_avx2 ||
+ pkt_burst == i40e_recv_pkts_vec_avx2)
options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_AVX2;
- else if (pkt_burst == i40e_recv_scattered_pkts_vec)
- options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_SSE |
- RTE_ETH_BURST_SCATTERED;
- else if (pkt_burst == i40e_recv_pkts_vec)
+ else if (pkt_burst == i40e_recv_scattered_pkts_vec ||
+ pkt_burst == i40e_recv_pkts_vec)
options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_SSE;
#elif defined(RTE_ARCH_ARM64)
- else if (pkt_burst == i40e_recv_scattered_pkts_vec)
- options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_NEON |
- RTE_ETH_BURST_SCATTERED;
- else if (pkt_burst == i40e_recv_pkts_vec)
+ else if (pkt_burst == i40e_recv_scattered_pkts_vec ||
+ pkt_burst == i40e_recv_pkts_vec)
options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_NEON;
#elif defined(RTE_ARCH_PPC_64)
- else if (pkt_burst == i40e_recv_scattered_pkts_vec)
- options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_ALTIVEC |
- RTE_ETH_BURST_SCATTERED;
- else if (pkt_burst == i40e_recv_pkts_vec)
+ else if (pkt_burst == i40e_recv_scattered_pkts_vec ||
+ pkt_burst == i40e_recv_pkts_vec)
options = RTE_ETH_BURST_VECTOR | RTE_ETH_BURST_ALTIVEC;
#endif
else
@@ -3162,9 +3152,8 @@ i40e_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,
eth_tx_burst_t pkt_burst = dev->tx_pkt_burst;
uint64_t options;
- if (pkt_burst == i40e_xmit_pkts_simple)
- options = RTE_ETH_BURST_SCALAR | RTE_ETH_BURST_SIMPLE;
- else if (pkt_burst == i40e_xmit_pkts)
+ if (pkt_burst == i40e_xmit_pkts_simple ||
+ pkt_burst == i40e_xmit_pkts)
options = RTE_ETH_BURST_SCALAR;
#ifdef RTE_ARCH_X86
else if (pkt_burst == i40e_xmit_pkts_vec_avx2)
--
2.17.1
next prev parent reply other threads:[~2019-10-31 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 17:11 [dpdk-dev] [PATCH v1 1/3] net/ice: " Haiyue Wang
2019-10-31 17:11 ` Haiyue Wang [this message]
2019-10-31 17:11 ` [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information Haiyue Wang
2019-11-01 22:46 ` Thomas Monjalon
2019-11-02 5:29 ` Wang, Haiyue
2019-11-02 6:55 ` Liu, Yu Y
2019-11-02 8:38 ` Slava Ovsiienko
2019-11-02 19:21 ` Damjan Marion (damarion)
2019-11-03 7:50 ` Slava Ovsiienko
2019-11-05 15:12 ` Ferruh Yigit
2019-11-05 15:54 ` Stephen Hemminger
2019-11-03 20:46 ` Ray Kinsella
2019-11-03 2:34 ` Wang, Haiyue
2019-11-03 3:03 ` Wang, Haiyue
2019-11-03 8:59 ` Slava Ovsiienko
2019-11-03 11:38 ` Wang, Haiyue
2019-11-03 19:31 ` Slava Ovsiienko
2019-11-04 1:01 ` Wang, Haiyue
2019-11-02 18:31 ` Thomas Monjalon
2019-11-03 3:52 ` Wang, Haiyue
2019-11-03 22:20 ` Thomas Monjalon
2019-11-04 0:51 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031171139.105110-2-haiyue.wang@intel.com \
--to=haiyue.wang@intel.com \
--cc=arybchenko@solarflare.com \
--cc=chenmin.sun@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=ray.kinsella@intel.com \
--cc=thomas@monjalon.net \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).