DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Ziyang Xuan <xuanziyang2@huawei.com>,
	dev@dpdk.org, ferruh.yigit@intel.com,
	cloud.wangxiaoyun@huawei.com, shahar.belkar@huawei.com,
	luoxianjun@huawei.com, tanya.brokhman@huawei.com
Subject: Re: [dpdk-dev] [PATCH v6 11/15] net/hinic: add hinic PMD build and doc files
Date: Mon, 4 Nov 2019 10:55:16 +0000	[thread overview]
Message-ID: <20191104105516.GA1356@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <ccacb367-f1ef-985a-c6a6-e8886a9813ca@solarflare.com>

On Tue, Oct 29, 2019 at 07:27:52PM +0300, Andrew Rybchenko wrote:
> On 10/29/19 6:50 PM, Stephen Hemminger wrote:
> > On Thu, 27 Jun 2019 16:18:20 +0800
> > Ziyang Xuan <xuanziyang2@huawei.com> wrote:
> > 
> > > +#
> > > +# Compile burst-oriented HINIC PMD driver
> > > +#
> > > +CONFIG_RTE_LIBRTE_HINIC_PMD=n
> > The most common naming convention for drivers is:
> > CONFIG_RTE_LIBRTE_PMD_XXX
> > 
> > so please use that.
> 
> It looks like we really need some conventions for all future PMDs:
> 
> $ git grep CONFIG_RTE_LIBRTE_PMD_ config/common_base | wc -l
> 59
> $ git grep CONFIG_RTE_LIBRTE_.*_PMD= config/common_base  | wc -l
> 40
> 
Yes, it is very inconsistent. However, for meson builds these defines are
automatically generated so follow only a single pattern. That pattern has
the PMD part at the end, so I recommend using that. From
drivers/net/meson.build:

	config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'

/Bruce

  reply	other threads:[~2019-11-04 10:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  8:10 [dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic Ziyang Xuan
2019-06-27  8:11 ` [dpdk-dev] [PATCH v6 01/15] net/hinic/base: add HW registers definition Ziyang Xuan
2019-06-27  8:12 ` [dpdk-dev] [PATCH v6 02/15] net/hinic/base: add HW interfaces of bar operation Ziyang Xuan
2019-06-27  8:13 ` [dpdk-dev] [PATCH v6 03/15] net/hinic/base: add API command channel code Ziyang Xuan
2019-06-27  8:14 ` [dpdk-dev] [PATCH v6 04/15] net/hinic/base: add support for cmdq mechanism Ziyang Xuan
2019-06-27  8:14 ` [dpdk-dev] [PATCH v6 05/15] net/hinic/base: add eq mechanism function code Ziyang Xuan
2019-06-27  8:15 ` [dpdk-dev] [PATCH v6 06/15] net/hinic/base: add mgmt module " Ziyang Xuan
2019-06-27  8:15 ` [dpdk-dev] [PATCH v6 07/15] net/hinic/base: add code about hardware operation Ziyang Xuan
2019-06-27  8:16 ` [dpdk-dev] [PATCH v6 08/15] net/hinic/base: add NIC business configurations Ziyang Xuan
2019-06-27  8:17 ` [dpdk-dev] [PATCH v6 09/15] net/hinic/base: add context and work queue support Ziyang Xuan
2019-06-27  8:17 ` [dpdk-dev] [PATCH v6 10/15] net/hinic/base: add various headers Ziyang Xuan
2019-06-27  8:18 ` [dpdk-dev] [PATCH v6 11/15] net/hinic: add hinic PMD build and doc files Ziyang Xuan
2019-10-29 15:50   ` Stephen Hemminger
2019-10-29 16:27     ` Andrew Rybchenko
2019-11-04 10:55       ` Bruce Richardson [this message]
2019-06-27  8:18 ` [dpdk-dev] [PATCH v6 12/15] net/hinic: add device initailization Ziyang Xuan
2019-06-27  8:19 ` [dpdk-dev] [PATCH v6 13/15] net/hinic: add start stop close queue ops Ziyang Xuan
2019-06-27  8:19 ` [dpdk-dev] [PATCH v6 14/15] net/hinic: add Rx/Tx package burst Ziyang Xuan
2019-07-11 13:59   ` Ferruh Yigit
2019-06-27  8:20 ` [dpdk-dev] [PATCH v6 15/15] net/hinic: add RSS stats promiscuous ops Ziyang Xuan
2019-06-27 14:26 ` [dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic Ferruh Yigit
2019-10-26 14:43   ` David Marchand
2019-10-29  6:43     ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-10-29  7:23       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104105516.GA1356@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=luoxianjun@huawei.com \
    --cc=shahar.belkar@huawei.com \
    --cc=stephen@networkplumber.org \
    --cc=tanya.brokhman@huawei.com \
    --cc=xuanziyang2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).