DPDK patches and discussions
 help / color / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: display more fields in dump
Date: Thu, 26 Dec 2019 08:58:51 -0800
Message-ID: <20191226085851.7f47ed81@hermes.lan> (raw)
In-Reply-To: <20191226161539.GI22738@platinum>

On Thu, 26 Dec 2019 17:15:39 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> Hi,
> 
> On Thu, Nov 21, 2019 at 10:30:55AM -0800, Stephen Hemminger wrote:
> > The rte_pktmbuf_dump should display offset, refcount, and vlan
> > info since these are often useful during debugging.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > v2 - remove casts, change in_port to port
> >      the refcount and offset are property of per-segment
> > 
> >  lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
> >  1 file changed, 10 insertions(+), 7 deletions(-)
> > 
> > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> > index 35df1c4c38a5..4894d46628e3 100644
> > --- a/lib/librte_mbuf/rte_mbuf.c
> > +++ b/lib/librte_mbuf/rte_mbuf.c
> > @@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
> >  
> >  	__rte_mbuf_sanity_check(m, 1);
> >  
> > -	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
> > -	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
> > -	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
> > -	       "in_port=%u\n", m->pkt_len, m->ol_flags,
> > -	       (unsigned)m->nb_segs, (unsigned)m->port);
> > +	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
> > +		m, m->buf_iova, m->buf_len);
> > +	fprintf(f,
> > +		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
> > +		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
> > +
> >  	nb_segs = m->nb_segs;
> >  
> >  	while (m && nb_segs != 0) {
> >  		__rte_mbuf_sanity_check(m, 0);
> >  
> > -		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
> > -			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
> > +		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
> > +			m, rte_pktmbuf_mtod(m, void *),
> > +			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
> > +
> >  		len = dump_len;
> >  		if (len > m->data_len)
> >  			len = m->data_len;
> > -- 
> > 2.20.1
> >   
> 
> Thanks for this enhancement.
> 
> One comment however: I don't see why vlan_tci would be important than
> packet type or rss tag. It is also a bit confusing to display a field
> which can have a random value (if the vlan flag is not set in ol_flags).
> 
> I'd prefer to dump vlan_tci only if the flag is present. Later we could
> add more fields with the same logic. What do you think?

Because this is a debugging hook and easier to always display the value.
Thats all.

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 17:41 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-11-21 16:16 ` Morten Brørup
2019-11-21 16:43   ` Stephen Hemminger
2019-11-21 18:30 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-11-22 12:31   ` Andrew Rybchenko
2019-12-26 16:15   ` Olivier Matz
2019-12-26 16:58     ` Stephen Hemminger [this message]
2019-12-27  9:10       ` Olivier Matz
2019-12-27 17:05         ` Stephen Hemminger
2019-12-30  8:11           ` Olivier Matz
2020-01-22 17:39 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2020-02-06  9:48   ` Olivier Matz
2020-02-06 14:32     ` Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191226085851.7f47ed81@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox