DPDK patches and discussions
 help / color / Atom feed
From: Morten Brørup <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump
Date: Thu, 21 Nov 2019 17:16:42 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C60C1B@smartserver.smartshare.dk> (raw)
In-Reply-To: <20191120174125.23704-1-stephen@networkplumber.org>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, November 20, 2019 6:41 PM
> 
> The rte_pktmbuf_dump should display offset, refcount, and vlan
> info since these are often useful during debugging.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_mbuf/rte_mbuf.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index 35df1c4c38a5..a964464bd598 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -473,11 +473,14 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf
> *m, unsigned dump_len)
> 
>  	__rte_mbuf_sanity_check(m, 1);
> 
> -	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
> -	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
> -	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u,
> "
> -	       "in_port=%u\n", m->pkt_len, m->ol_flags,
> -	       (unsigned)m->nb_segs, (unsigned)m->port);
> +	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u,"
> +		" offs=%u, refcnt=%u\n",
> +		m, (uint64_t)m->buf_iova, (unsigned)m->buf_len,
> +		(unsigned)m->data_off, (unsigned)rte_mbuf_refcnt_read(m));
> +	fprintf(f, "  pkt_len=%u, ol_flags=%#"PRIx64","
> +		" nb_segs=%u, in_port=%u, vlan_tci=%#x\n",
> +		(unsigned)m->pkt_len, m->ol_flags,
> +		(unsigned)m->nb_segs, (unsigned)m->port, (unsigned)m-
> >vlan_tci);

Are all these explicit type casts really needed? buf_iova is already uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, vlan_tci is uint16_t.

m->port is not only the input port anymore (ref. the mbuf documentation), so please change in_port=%u to port=%u.

For consistency with ol_flags and vlan_tci format, consider changing iova=% to iova=%#.

>  	nb_segs = m->nb_segs;
> 
>  	while (m && nb_segs != 0) {
> --
> 2.20.1
> 


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 17:41 Stephen Hemminger
2019-11-21 16:16 ` Morten Brørup [this message]
2019-11-21 16:43   ` Stephen Hemminger
2019-11-21 18:30 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-11-22 12:31   ` Andrew Rybchenko
2019-12-26 16:15   ` Olivier Matz
2019-12-26 16:58     ` Stephen Hemminger
2019-12-27  9:10       ` Olivier Matz
2019-12-27 17:05         ` Stephen Hemminger
2019-12-30  8:11           ` Olivier Matz
2020-01-22 17:39 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2020-02-06  9:48   ` Olivier Matz
2020-02-06 14:32     ` Thomas Monjalon
2019-11-21 17:04 [dpdk-dev] [PATCH] " Morten Brørup

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35C60C1B@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox