From: Ye Xiaolong <xiaolong.ye@intel.com> To: "Mcnamara, John" <john.mcnamara@intel.com> Cc: "Kovacevic, Marko" <marko.kovacevic@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, Stephen Hemminger <stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide Date: Sat, 18 Jan 2020 09:52:05 +0800 Message-ID: <20200118015205.GO33538@intel.com> (raw) In-Reply-To: <MWHPR1101MB2158BEADC075D5051D783D61FC310@MWHPR1101MB2158.namprd11.prod.outlook.com> Hi, John Thanks for your review. On 01/17, Mcnamara, John wrote: >Hi, > >Overall looks good. Some notes below: > >> + >> +.. note:: >> + >> +For compiling the NUMA lib, run libtool --version to ensure the >> +libtool version >= 2.2, otherwise the compilation will fail with errors. > > >This continuation line isn't indented and raised a build error: > > $ make doc-guides-html > sphinx processing guides-html... > /work/dpdk_docs/doc/guides/howto/openwrt.rst:80: WARNING: > Explicit markup ends without a blank line; unexpected unindent. > >Also you should used spaces not tabs for indentation in the docs. Got it. > >> +If you are using Windows PC, you can use some free and opensource raw >> +disk image writer program such as >> +``Win32 Disk Imager`` and ``Etcher`` to write OpenWrt image >> +(openwrt-x86-64-combined-ext4.img) to a USB flash driver or USB SDcard >> with SDcard or a Sata hard drivre or SSD from your PC. > >Typo: drive > >I'll send you a few other suggested minor corrections. I'll send a new version after I correct all the suggestions. Thanks, Xiaolong > >John >
next prev parent reply other threads:[~2020-01-18 1:53 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-29 8:19 [dpdk-dev] [PATCH] " Xiaolong Ye 2019-11-29 10:09 ` Bruce Richardson 2019-11-29 15:03 ` Ye Xiaolong 2019-11-29 16:59 ` Stephen Hemminger 2019-12-01 11:30 ` Ye Xiaolong 2019-12-02 6:34 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye 2019-12-02 7:31 ` Jerin Jacob 2019-12-02 8:09 ` Ye Xiaolong 2019-12-12 2:25 ` [dpdk-dev] [PATCH v3] " Xiaolong Ye 2019-12-16 3:01 ` [dpdk-dev] [PATCH v4] " Xiaolong Ye 2019-12-19 6:05 ` Zhang, Xiao 2020-01-17 13:46 ` Mcnamara, John 2020-01-18 1:52 ` Ye Xiaolong [this message] 2020-01-18 5:48 ` [dpdk-dev] [PATCH v5] " Xiaolong Ye 2020-01-22 12:34 ` Mcnamara, John 2020-02-16 11:04 ` Thomas Monjalon 2020-02-16 17:29 ` Ye Xiaolong 2020-02-16 18:02 ` Thomas Monjalon 2020-02-17 1:18 ` Ye Xiaolong 2020-02-17 3:12 ` Dmitry Kozlyuk 2020-02-17 6:21 ` Ye Xiaolong 2020-02-17 2:47 ` [dpdk-dev] [PATCH v6] " Xiaolong Ye 2020-02-17 15:08 ` Ray Kinsella 2020-02-17 15:44 ` Ye Xiaolong 2020-02-17 15:49 ` Ray Kinsella 2020-02-18 8:26 ` Mcnamara, John 2020-02-18 9:12 ` Ray Kinsella 2020-02-18 9:32 ` Thomas Monjalon 2020-02-18 9:49 ` Ye Xiaolong 2020-02-18 10:08 ` Ray Kinsella 2020-02-21 21:08 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200118015205.GO33538@intel.com \ --to=xiaolong.ye@intel.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=john.mcnamara@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git