DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: add note for vhost builtin example
@ 2020-03-25  1:40 Xuan Ding
  2020-03-25  4:21 ` [dpdk-dev] [PATCH v2] " Xuan Ding
  0 siblings, 1 reply; 4+ messages in thread
From: Xuan Ding @ 2020-03-25  1:40 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, xiaolong.ye; +Cc: dev, Xuan Ding

Add memory pre-allocation note for vhost example when enabling
"builtin-net-driver".

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
 doc/guides/sample_app_ug/vhost.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst
index a71ada654..1db3ae931 100644
--- a/doc/guides/sample_app_ug/vhost.rst
+++ b/doc/guides/sample_app_ug/vhost.rst
@@ -201,3 +201,9 @@ Common Issues
 
   QEMU vhost net device start will fail if protocol feature is not negotiated.
   DPDK virtio-user pmd can be the replacement of QEMU.
+
+* Device start fails when enabling "builtin-net-driver" without memory
+  pre-allocation
+
+  The builtin example doesn't support dynamic memory allocation. "--socket-mem"
+  option need to be added when enabling "builtin-net-driver".
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] doc: add note for vhost builtin example
  2020-03-25  1:40 [dpdk-dev] [PATCH] doc: add note for vhost builtin example Xuan Ding
@ 2020-03-25  4:21 ` Xuan Ding
  2020-04-15 11:10   ` Maxime Coquelin
  2020-04-17 17:13   ` Maxime Coquelin
  0 siblings, 2 replies; 4+ messages in thread
From: Xuan Ding @ 2020-03-25  4:21 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, xiaolong.ye; +Cc: dev, Xuan Ding

Add memory pre-allocation note for vhost example when enabling
"builtin-net-driver".

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---

v2:
* Modified expression in doc to make it more accurate.
---
 doc/guides/sample_app_ug/vhost.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst
index a71ada654..b7ed4f8bd 100644
--- a/doc/guides/sample_app_ug/vhost.rst
+++ b/doc/guides/sample_app_ug/vhost.rst
@@ -201,3 +201,10 @@ Common Issues
 
   QEMU vhost net device start will fail if protocol feature is not negotiated.
   DPDK virtio-user pmd can be the replacement of QEMU.
+
+* Device start fails when enabling "builtin-net-driver" without memory
+  pre-allocation
+
+  The builtin example doesn't support dynamic memory allocation. When vhost
+  backend enables "builtin-net-driver", "--socket-mem" option should be
+  added at virtio-user pmd side as a startup item.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: add note for vhost builtin example
  2020-03-25  4:21 ` [dpdk-dev] [PATCH v2] " Xuan Ding
@ 2020-04-15 11:10   ` Maxime Coquelin
  2020-04-17 17:13   ` Maxime Coquelin
  1 sibling, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-04-15 11:10 UTC (permalink / raw)
  To: Xuan Ding, zhihong.wang, xiaolong.ye; +Cc: dev



On 3/25/20 5:21 AM, Xuan Ding wrote:
> Add memory pre-allocation note for vhost example when enabling
> "builtin-net-driver".
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> 
> v2:
> * Modified expression in doc to make it more accurate.
> ---
>  doc/guides/sample_app_ug/vhost.rst | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: add note for vhost builtin example
  2020-03-25  4:21 ` [dpdk-dev] [PATCH v2] " Xuan Ding
  2020-04-15 11:10   ` Maxime Coquelin
@ 2020-04-17 17:13   ` Maxime Coquelin
  1 sibling, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-04-17 17:13 UTC (permalink / raw)
  To: Xuan Ding, zhihong.wang, xiaolong.ye; +Cc: dev



On 3/25/20 5:21 AM, Xuan Ding wrote:
> Add memory pre-allocation note for vhost example when enabling
> "builtin-net-driver".
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> 
> v2:
> * Modified expression in doc to make it more accurate.
> ---
>  doc/guides/sample_app_ug/vhost.rst | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to dpdk-next-virtio/master

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-17 17:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25  1:40 [dpdk-dev] [PATCH] doc: add note for vhost builtin example Xuan Ding
2020-03-25  4:21 ` [dpdk-dev] [PATCH v2] " Xuan Ding
2020-04-15 11:10   ` Maxime Coquelin
2020-04-17 17:13   ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).