DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] config: update MAX_FRAG to support jumbo packets
@ 2020-04-01  8:35 Apeksha Gupta
  2020-04-06 16:55 ` Ananyev, Konstantin
  0 siblings, 1 reply; 2+ messages in thread
From: Apeksha Gupta @ 2020-04-01  8:35 UTC (permalink / raw)
  To: akhil.goyal; +Cc: thomas, dev, hemant.agrawal, Apeksha Gupta, stable

RTE_LIBRTE_IP_FRAG_MAX_FRAG flag value increased from 4 to 8. By this
pkt size greater than 6000 is supported in ip-fragmentation and
ip-reassembly.

Fixes: 9788b93b9d5 ("config: MAX_FRAG updated to support the jumbo
packets")
Cc: stable@dpdk.org

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
 config/common_base  | 2 +-
 config/rte_config.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/common_base b/config/common_base
index e231384e88..be4a6bafb5 100644
--- a/config/common_base
+++ b/config/common_base
@@ -950,7 +950,7 @@ CONFIG_RTE_LIBRTE_NET=y
 #
 CONFIG_RTE_LIBRTE_IP_FRAG=y
 CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n
-CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4
+CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=8
 CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n
 
 #
diff --git a/config/rte_config.h b/config/rte_config.h
index d30786bc08..f5cdc3ddbe 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -82,7 +82,7 @@
 #define RTE_RAWDEV_MAX_DEVS 64
 
 /* ip_fragmentation defines */
-#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
+#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
 #undef RTE_LIBRTE_IP_FRAG_TBL_STAT
 
 /* rte_power defines */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] config: update MAX_FRAG to support jumbo packets
  2020-04-01  8:35 [dpdk-dev] [PATCH] config: update MAX_FRAG to support jumbo packets Apeksha Gupta
@ 2020-04-06 16:55 ` Ananyev, Konstantin
  0 siblings, 0 replies; 2+ messages in thread
From: Ananyev, Konstantin @ 2020-04-06 16:55 UTC (permalink / raw)
  To: Apeksha Gupta, akhil.goyal; +Cc: thomas, dev, hemant.agrawal, stable

> 
> RTE_LIBRTE_IP_FRAG_MAX_FRAG flag value increased from 4 to 8. By this
> pkt size greater than 6000 is supported in ip-fragmentation and
> ip-reassembly.
> 
> Fixes: 9788b93b9d5 ("config: MAX_FRAG updated to support the jumbo
> packets")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
>  config/common_base  | 2 +-
>  config/rte_config.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/config/common_base b/config/common_base
> index e231384e88..be4a6bafb5 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -950,7 +950,7 @@ CONFIG_RTE_LIBRTE_NET=y
>  #
>  CONFIG_RTE_LIBRTE_IP_FRAG=y
>  CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n
> -CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4
> +CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=8
>  CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n
> 
>  #
> diff --git a/config/rte_config.h b/config/rte_config.h
> index d30786bc08..f5cdc3ddbe 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -82,7 +82,7 @@
>  #define RTE_RAWDEV_MAX_DEVS 64
> 
>  /* ip_fragmentation defines */
> -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
> +#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
>  #undef RTE_LIBRTE_IP_FRAG_TBL_STAT

Not sure it is a good idea - it will double size of reassembly table
(and number of required mbufs) for users who use default value. 
The proper way would be, I think to restructure reassemble code,
to make max_frag_num an extra parameter for rte_ip_frag_table_create(). 

> 
>  /* rte_power defines */
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-06 16:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01  8:35 [dpdk-dev] [PATCH] config: update MAX_FRAG to support jumbo packets Apeksha Gupta
2020-04-06 16:55 ` Ananyev, Konstantin

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git