DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, matan@mellanox.com, chenbo.xia@intel.com,
	yong.liu@intel.com, yinan.wang@intel.com
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
	david.marchand@redhat.com,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v4 0/3] Fix Vhost regressions
Date: Wed, 29 Jul 2020 15:36:23 +0200	[thread overview]
Message-ID: <20200729133626.237098-1-maxime.coquelin@redhat.com> (raw)

This series aims at fixing the regressions reported by Intel QE.
I managed to reproduce the issues, and this series fixes them.

The two first patches fix the performance regression. They have
been tested by intel QE which confirms the fix.

Patch 3 aims at fixing interrupt mode.

In this v4, only changes are adding NULL check on the intr handle,
to avoid segfault reproduced with using Virtio-user on the other end
when quitting testpmd. It also add an error log when a valid kickfd
get updated as suggested by David as it should not happen. Minor typos
reported by David are also fixed.

There are still l3fwd-power flooding errors when leaving, but these
were already here in v20.05. This is an issue in the application,
not the PMD driver.

Thanks to Intel QE team for all the validation work!
Maxime


Maxime Coquelin (3):
  vhost: fix guest notification setting
  net/vhost: fix queue update
  net/vhost: fix interrupt mode

 drivers/net/vhost/rte_eth_vhost.c | 109 +++++++++++++++++++++++-------
 lib/librte_vhost/vhost.c          |  24 +++++--
 lib/librte_vhost/vhost.h          |   5 ++
 lib/librte_vhost/vhost_user.c     |  11 ++-
 4 files changed, 118 insertions(+), 31 deletions(-)

-- 
2.26.2


             reply	other threads:[~2020-07-29 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 13:36 Maxime Coquelin [this message]
2020-07-29 13:36 ` [dpdk-dev] [PATCH v4 1/3] vhost: fix guest notification setting Maxime Coquelin
2020-07-29 13:36 ` [dpdk-dev] [PATCH v4 2/3] net/vhost: fix queue update Maxime Coquelin
2020-07-29 13:36 ` [dpdk-dev] [PATCH v4 3/3] net/vhost: fix interrupt mode Maxime Coquelin
2020-07-29 14:18   ` Xia, Chenbo
2020-07-30  5:48     ` Xiao, QimaiX
2020-07-29 14:54 ` [dpdk-dev] [PATCH v4 0/3] Fix Vhost regressions Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729133626.237098-1-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yinan.wang@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).