DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] net/bnxt: add a check in bnxt PCI probe
@ 2020-09-25 10:38 Somnath Kotur
  0 siblings, 0 replies; 3+ messages in thread
From: Somnath Kotur @ 2020-09-25 10:38 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, Somnath Kotur, Venkat Duvvuru

Check for num_rep before invoking rep port probe.

Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")

Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
---
v2: Check against num_rep instead of devargs ptr
 drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index db2f0dde4..ab25dd1b1 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -6147,6 +6147,10 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	}
 	PMD_DRV_LOG(DEBUG, "BNXT Port:%d pci probe\n",
 		    backing_eth_dev->data->port_id);
+
+	if (!num_rep)
+		return ret;
+
 	/* probe representor ports now */
 	ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev);
 
-- 
2.28.0.497.g54e85e7


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/bnxt: add a check in bnxt PCI probe
  2020-09-25 10:40 ` [dpdk-dev] [PATCH v2] net/bnxt: add a " Somnath Kotur
@ 2020-09-25 11:56   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-09-25 11:56 UTC (permalink / raw)
  To: Somnath Kotur, dev; +Cc: Venkat Duvvuru

On 9/25/2020 11:40 AM, Somnath Kotur wrote:
> Check for num_rep before invoking rep port probe.
> 
> Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> 
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH v2] net/bnxt: add a check in bnxt PCI probe
  2020-09-22  7:06 [dpdk-dev] [PATCH 5/8] net/bnxt: add a null ptr " Somnath Kotur
@ 2020-09-25 10:40 ` Somnath Kotur
  2020-09-25 11:56   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Somnath Kotur @ 2020-09-25 10:40 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, Somnath Kotur, Venkat Duvvuru

Check for num_rep before invoking rep port probe.

Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")

Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
---
v2: Check against num_rep instead of devargs ptr
 drivers/net/bnxt/bnxt_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index db2f0dde4..ab25dd1b1 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -6147,6 +6147,10 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	}
 	PMD_DRV_LOG(DEBUG, "BNXT Port:%d pci probe\n",
 		    backing_eth_dev->data->port_id);
+
+	if (!num_rep)
+		return ret;
+
 	/* probe representor ports now */
 	ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev);
 
-- 
2.28.0.497.g54e85e7


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-25 11:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 10:38 [dpdk-dev] [PATCH v2] net/bnxt: add a check in bnxt PCI probe Somnath Kotur
  -- strict thread matches above, loose matches on Subject: below --
2020-09-22  7:06 [dpdk-dev] [PATCH 5/8] net/bnxt: add a null ptr " Somnath Kotur
2020-09-25 10:40 ` [dpdk-dev] [PATCH v2] net/bnxt: add a " Somnath Kotur
2020-09-25 11:56   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).