From: Ferruh Yigit <ferruh.yigit@intel.com> To: Maryam Tahhan <maryam.tahhan@intel.com>, Reshma Pattan <reshma.pattan@intel.com>, John McNamara <john.mcnamara@intel.com>, Vipin Varghese <vipin.varghese@intel.com> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org Subject: [dpdk-dev] [PATCH 3/4] app/procinfo: remove suspicious sizeof Date: Tue, 17 Nov 2020 17:14:34 +0000 Message-ID: <20201117171435.2303641-4-ferruh.yigit@intel.com> (raw) In-Reply-To: <20201117171435.2303641-1-ferruh.yigit@intel.com> The intention with the "sizeof(0)" usage is not clear, but the 'stats' already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' in application. Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- Cc: vipin.varghese@intel.com --- app/proc-info/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c11fe25af4..dc5cc92209 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1207,7 +1207,6 @@ show_crypto(void) display_crypto_feature_info(dev_info.feature_flags); - memset(&stats, 0, sizeof(0)); if (rte_cryptodev_stats_get(i, &stats) == 0) { printf("\t -- stats\n"); printf("\t\t + enqueue count (%"PRIu64")" -- 2.26.2
next prev parent reply other threads:[~2020-11-17 17:15 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-17 17:14 [dpdk-dev] [PATCH 0/4] cppcheck Ferruh Yigit 2020-11-17 17:14 ` [dpdk-dev] [PATCH 1/4] app/procinfo: fix redundant condition Ferruh Yigit 2020-11-17 17:14 ` [dpdk-dev] [PATCH 2/4] app/procinfo: fix negative check on unsigned variable Ferruh Yigit 2020-11-17 17:14 ` Ferruh Yigit [this message] 2020-11-17 18:07 ` [dpdk-dev] [PATCH 3/4] app/procinfo: remove suspicious sizeof Varghese, Vipin 2020-11-17 17:14 ` [dpdk-dev] [PATCH 4/4] app/procinfo: remove useless assignment Ferruh Yigit 2020-11-17 18:04 ` Varghese, Vipin 2020-11-18 10:46 ` Ferruh Yigit 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 0/7] cppcheck Ferruh Yigit 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition Ferruh Yigit 2020-11-18 14:10 ` David Marchand 2020-11-19 9:34 ` Ferruh Yigit 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 2/7] app/procinfo: fix negative check on unsigned variable Ferruh Yigit 2020-11-18 14:10 ` [dpdk-dev] [dpdk-stable] " David Marchand 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 3/7] app/procinfo: remove suspicious sizeof Ferruh Yigit 2020-11-18 14:10 ` [dpdk-dev] [dpdk-stable] " David Marchand 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 4/7] app/procinfo: remove useless assignment Ferruh Yigit 2020-11-18 14:11 ` David Marchand 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 5/7] net/pcap: remove local variable shadown outer one Ferruh Yigit 2020-11-18 14:11 ` David Marchand 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 6/7] net/af_xdp: remove useless assignment Ferruh Yigit 2020-11-18 14:42 ` David Marchand 2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 7/7] net/bnxt: fix redundant return Ferruh Yigit 2020-11-18 14:42 ` [dpdk-dev] [dpdk-stable] " David Marchand 2020-11-18 16:12 ` Ajit Khaparde
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201117171435.2303641-4-ferruh.yigit@intel.com \ --to=ferruh.yigit@intel.com \ --cc=dev@dpdk.org \ --cc=john.mcnamara@intel.com \ --cc=maryam.tahhan@intel.com \ --cc=reshma.pattan@intel.com \ --cc=stable@dpdk.org \ --cc=vipin.varghese@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git