DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raja Zidane <rzidane@nvidia.com>
To: <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>
Subject: [dpdk-dev] [PATCH 2/2] common/mlx5: fix MMO configuration in QP
Date: Thu, 28 Oct 2021 13:58:50 +0000	[thread overview]
Message-ID: <20211028135850.6633-3-rzidane@nvidia.com> (raw)
In-Reply-To: <20211028135850.6633-1-rzidane@nvidia.com>

The QP extension valid bit was not set in the QP creation for MMO
configuration.
That caused the QP not to be connected to the GGA MMO engines,
and any MMO WQE job got CQE with an error.
Set the QP ext bit when MMO is configured.

Fixes: ddda0006188a ("common/mlx5: add MMO configuration for DevX queue pair")

Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index fb7c8e986f..4f6a73510d 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -2055,6 +2055,8 @@ mlx5_devx_cmd_create_qp(void *ctx,
 				in, qpc_extension_and_pas_list);
 			void *qpc_ext = MLX5_ADDR_OF(qpc_extension_and_pas_list,
 				qpc_ext_and_pas_list, qpc_data_extension);
+
+			MLX5_SET(create_qp_in, in, qpc_ext, 1);
 			MLX5_SET(qpc_extension, qpc_ext, mmo, 1);
 		}
 		MLX5_SET(qpc, qpc, pm_state, MLX5_QP_PM_MIGRATED);
-- 
2.17.1


  parent reply	other threads:[~2021-10-28 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 13:58 [dpdk-dev] [PATCH 0/2] fix MMO QP usage Raja Zidane
2021-10-28 13:58 ` [dpdk-dev] [PATCH 1/2] common/mlx5: fix HCA cap PRM alignment Raja Zidane
2021-10-28 13:58 ` Raja Zidane [this message]
2021-10-28 18:17 ` [dpdk-dev] [PATCH 0/2] fix MMO QP usage Matan Azrad
2021-11-08  8:44   ` Thomas Monjalon
2021-11-04  8:55 ` Matan Azrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028135850.6633-3-rzidane@nvidia.com \
    --to=rzidane@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).