From: Yanling Song <songyl@ramaxel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,
<xuyun@ramaxel.com>, <stephen@networkplumber.org>,
<lihuisong@huawei.com>
Subject: Re: [PATCH v6 26/26] net/spnic: fixes unsafe C style code
Date: Fri, 21 Jan 2022 17:40:23 +0800 [thread overview]
Message-ID: <20220121174023.00003747@ramaxel.com> (raw)
In-Reply-To: <aa18bb91-b2a3-9b89-5da7-a78a88390c11@intel.com>
On Wed, 19 Jan 2022 17:28:11 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 12/30/2021 6:09 AM, Yanling Song wrote:
> > Use the hardware structure instead of void* as parameter of
> > function to keep the type information
>
> Hi Yanling,
>
> This is a new driver and first patchset for it. Instead of fixing it
> in the set, why not update old patches to introduce them correct at
> first place?
>
Thanks for the guide. Will do it this way in the next version.
> >
> > Signed-off-by: Yanling Song <songyl@ramaxel.com>
> > ---
> > drivers/net/spnic/base/spnic_cmdq.c | 14 +--
> > drivers/net/spnic/base/spnic_cmdq.h | 6 +-
> > drivers/net/spnic/base/spnic_hw_cfg.c | 49 ++++------
> > drivers/net/spnic/base/spnic_hw_cfg.h | 16 ++--
> > drivers/net/spnic/base/spnic_hw_comm.c | 32 ++++---
> > drivers/net/spnic/base/spnic_hw_comm.h | 22 ++---
> > drivers/net/spnic/base/spnic_hwdev.c | 8 +-
> > drivers/net/spnic/base/spnic_hwif.c | 52 +++++------
> > drivers/net/spnic/base/spnic_hwif.h | 22 ++---
> > drivers/net/spnic/base/spnic_mgmt.c | 9 +-
> > drivers/net/spnic/base/spnic_mgmt.h | 4 +-
> > drivers/net/spnic/base/spnic_nic_cfg.c | 110
> > +++++++++++------------ drivers/net/spnic/base/spnic_nic_cfg.h |
> > 84 ++++++++--------- drivers/net/spnic/base/spnic_nic_event.c | 30
> > +++---- drivers/net/spnic/base/spnic_nic_event.h | 10 +--
> > drivers/net/spnic/base/spnic_wq.c | 3 +-
> > drivers/net/spnic/base/spnic_wq.h | 2 +-
> > drivers/net/spnic/spnic_ethdev.c | 10 +--
> > drivers/net/spnic/spnic_io.c | 34 +++----
> > drivers/net/spnic/spnic_io.h | 10 +--
> > drivers/net/spnic/spnic_rx.c | 4 +-
> > drivers/net/spnic/spnic_tx.c | 4 +-
> > 22 files changed, 252 insertions(+), 283 deletions(-)
>
>
> <...>
>
next prev parent reply other threads:[~2022-01-21 9:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 6:08 [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03 Yanling Song
2021-12-30 6:08 ` [PATCH v6 01/26] drivers/net: introduce a new PMD driver Yanling Song
2022-01-19 16:58 ` Ferruh Yigit
2021-12-30 6:08 ` [PATCH v6 02/26] net/spnic: initialize the HW interface Yanling Song
2022-01-19 17:05 ` Ferruh Yigit
2022-01-21 9:32 ` Yanling Song
2021-12-30 6:08 ` [PATCH v6 03/26] net/spnic: add mbox message channel Yanling Song
2021-12-30 6:08 ` [PATCH v6 04/26] net/spnic: introduce event queue Yanling Song
2021-12-30 6:08 ` [PATCH v6 05/26] net/spnic: add mgmt module Yanling Song
2022-01-19 17:22 ` Ferruh Yigit
2022-01-21 9:33 ` Yanling Song
2021-12-30 6:08 ` [PATCH v6 06/26] net/spnic: add cmdq and work queue Yanling Song
2021-12-30 6:08 ` [PATCH v6 07/26] net/spnic: add interface handling cmdq message Yanling Song
2021-12-30 6:08 ` [PATCH v6 08/26] net/spnic: add hardware info initialization Yanling Song
2021-12-30 6:08 ` [PATCH v6 09/26] net/spnic: support MAC and link event handling Yanling Song
2022-01-19 17:26 ` Ferruh Yigit
2022-01-21 9:36 ` Yanling Song
2021-12-30 6:08 ` [PATCH v6 10/26] net/spnic: add function info initialization Yanling Song
2021-12-30 6:08 ` [PATCH v6 11/26] net/spnic: add queue pairs context initialization Yanling Song
2021-12-30 6:08 ` [PATCH v6 12/26] net/spnic: support mbuf handling of Tx/Rx Yanling Song
2021-12-30 6:08 ` [PATCH v6 13/26] net/spnic: support Rx congfiguration Yanling Song
2021-12-30 6:08 ` [PATCH v6 14/26] net/spnic: add port/vport enable Yanling Song
2021-12-30 6:08 ` [PATCH v6 15/26] net/spnic: support IO packets handling Yanling Song
2021-12-30 6:08 ` [PATCH v6 16/26] net/spnic: add device configure/version/info Yanling Song
2021-12-30 6:08 ` [PATCH v6 17/26] net/spnic: support RSS configuration update and get Yanling Song
2021-12-30 6:08 ` [PATCH v6 18/26] net/spnic: support VLAN filtering and offloading Yanling Song
2021-12-30 6:08 ` [PATCH v6 19/26] net/spnic: support promiscuous and allmulticast Rx modes Yanling Song
2021-12-30 6:08 ` [PATCH v6 20/26] net/spnic: support flow control Yanling Song
2021-12-30 6:08 ` [PATCH v6 21/26] net/spnic: support getting Tx/Rx queues info Yanling Song
2021-12-30 6:09 ` [PATCH v6 22/26] net/spnic: net/spnic: support xstats statistics Yanling Song
2021-12-30 6:09 ` [PATCH v6 23/26] net/spnic: support VFIO interrupt Yanling Song
2021-12-30 6:09 ` [PATCH v6 24/26] net/spnic: support Tx/Rx queue start/stop Yanling Song
2021-12-30 6:09 ` [PATCH v6 25/26] net/spnic: add doc infrastructure Yanling Song
2022-01-19 17:27 ` Ferruh Yigit
2022-01-21 9:39 ` Yanling Song
2021-12-30 6:09 ` [PATCH v6 26/26] net/spnic: fixes unsafe C style code Yanling Song
2022-01-19 17:28 ` Ferruh Yigit
2022-01-21 9:40 ` Yanling Song [this message]
2022-01-19 16:56 ` [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03 Ferruh Yigit
2022-01-21 9:27 ` Yanling Song
2022-01-21 10:22 ` Ferruh Yigit
2022-01-24 5:12 ` Hemant Agrawal
2022-02-12 14:01 ` Yanling Song
2022-02-13 18:07 ` Thomas Monjalon
2022-02-18 9:30 ` Yanling Song
2023-04-13 9:02 ` Ferruh Yigit
2023-07-31 14:08 ` Thomas Monjalon
2022-02-16 14:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121174023.00003747@ramaxel.com \
--to=songyl@ramaxel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lihuisong@huawei.com \
--cc=stephen@networkplumber.org \
--cc=xuyun@ramaxel.com \
--cc=yanggan@ramaxel.com \
--cc=yanling.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).