From: Stephen Hemminger <stephen@networkplumber.org>
To: Mike Pattrick <mkp@redhat.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH v2] vhost: exclude VM hugepages from coredumps
Date: Fri, 3 Feb 2023 09:45:45 -0800 [thread overview]
Message-ID: <20230203094545.1e91f183@hermes.local> (raw)
In-Reply-To: <20221206150509.772408-1-mkp@redhat.com>
On Tue, 6 Dec 2022 10:05:09 -0500
Mike Pattrick <mkp@redhat.com> wrote:
> +
> +static __rte_always_inline void
> +mem_set_dump(__rte_unused void *ptr, __rte_unused size_t size, __rte_unused bool enable)
> +{
> +#ifdef MADV_DONTDUMP
> + if (madvise(ptr, size, enable ? MADV_DODUMP : MADV_DONTDUMP) == -1) {
> + rte_log(RTE_LOG_INFO, vhost_config_log_level,
> + "VHOST_CONFIG: could not set coredump preference (%s).\n", strerror(errno));
> + }
> +#endif
> +}
Why is this inlined in vhost.h? Hardly a critical path function.
next prev parent reply other threads:[~2023-02-03 17:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 15:05 Mike Pattrick
2022-12-07 16:54 ` [PATCH v3] " Mike Pattrick
2022-12-20 12:43 ` Maxime Coquelin
2023-02-03 14:50 ` Maxime Coquelin
2023-02-10 15:53 ` David Marchand
2023-02-10 15:59 ` Maxime Coquelin
2023-02-10 21:12 ` Mike Pattrick
2023-02-21 16:26 ` Maxime Coquelin
2023-02-22 13:59 ` Mike Pattrick
2023-02-22 21:43 ` [PATCH] vhost: fix madvise arguments alignment Mike Pattrick
2023-02-23 4:35 ` [PATCH v2] " Mike Pattrick
2023-02-23 16:12 ` Maxime Coquelin
2023-02-23 16:57 ` Mike Pattrick
2023-02-24 15:05 ` Patrick Robb
2023-03-01 20:02 ` [PATCH v3] " Mike Pattrick
2023-03-02 10:19 ` Maxime Coquelin
2023-03-06 14:22 ` Maxime Coquelin
2023-02-03 17:45 ` Stephen Hemminger [this message]
2023-02-06 1:13 ` [PATCH v2] vhost: exclude VM hugepages from coredumps Mike Pattrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203094545.1e91f183@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=mkp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).