[PATCH] net/mlx5: fix build failure on Windows

[PATCH] net/mlx5: fix build failure on Windows

[Maxime Coquelin]

__always_inline is not supported on Windows, let's use
__rte_always_inline instead.

..\drivers\net\mlx5/mlx5_hws_cnt.h:162:8: error: unknown type name '__always_inline'

static __always_inline struct mlx5_hws_cnt_pool *

       ^

..\drivers\net\mlx5/mlx5_hws_cnt.h:165:9: error: incompatible pointer types returning 'struct mlx5_hws_cnt_pool *' from a function with result type 'int *' [-Werror,-Wincompatible-pointer-types]

        return cpool->cfg.host_cpool ? cpool->cfg.host_cpool : cpool;

Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode")

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/net/mlx5/mlx5_hws_cnt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5/mlx5_hws_cnt.h
index d35d083eeb..b4f3db0533 100644
--- a/drivers/net/mlx5/mlx5_hws_cnt.h
+++ b/drivers/net/mlx5/mlx5_hws_cnt.h
@@ -159,7 +159,7 @@ struct mlx5_hws_age_param {
  * @return
  *   Internal index
  */
-static __always_inline struct mlx5_hws_cnt_pool *
+static __rte_always_inline struct mlx5_hws_cnt_pool *
 mlx5_hws_cnt_host_pool(struct mlx5_hws_cnt_pool *cpool)
 {
 	return cpool->cfg.host_cpool ? cpool->cfg.host_cpool : cpool;
-- 
2.39.1

Re: [PATCH] net/mlx5: fix build failure on Windows

[Thomas Monjalon]

17/02/2023 15:37, Maxime Coquelin:
> __always_inline is not supported on Windows, let's use
> __rte_always_inline instead.
> 
> ..\drivers\net\mlx5/mlx5_hws_cnt.h:162:8: error: unknown type name '__always_inline'
> 
> static __always_inline struct mlx5_hws_cnt_pool *
> 
>        ^
> 
> ..\drivers\net\mlx5/mlx5_hws_cnt.h:165:9: error: incompatible pointer types returning 'struct mlx5_hws_cnt_pool *' from a function with result type 'int *' [-Werror,-Wincompatible-pointer-types]
> 
>         return cpool->cfg.host_cpool ? cpool->cfg.host_cpool : cpool;
> 
> Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode")
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied, thanks.

RE: [PATCH] net/mlx5: fix build failure on Windows

[Slava Ovsiienko]

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, February 17, 2023 4:37 PM
> To: dev@dpdk.org; Slava Ovsiienko <viacheslavo@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] net/mlx5: fix build failure on Windows
> 
> __always_inline is not supported on Windows, let's use __rte_always_inline
> instead.
> 
> ..\drivers\net\mlx5/mlx5_hws_cnt.h:162:8: error: unknown type name
> '__always_inline'
> 
> static __always_inline struct mlx5_hws_cnt_pool *
> 
>        ^
> 
> ..\drivers\net\mlx5/mlx5_hws_cnt.h:165:9: error: incompatible pointer types
> returning 'struct mlx5_hws_cnt_pool *' from a function with result type 'int *' [-
> Werror,-Wincompatible-pointer-types]
> 
>         return cpool->cfg.host_cpool ? cpool->cfg.host_cpool : cpool;
> 
> Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode")
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Thank you for the fix,
With best regards,
Slava