From: Zhuobin Huang <zobin1999@gmail.com>
To: dev@dpdk.org
Cc: cunming.liang@intel.com
Subject: [PATCH v2] app/test: fix data length of each packet segment
Date: Mon, 6 Mar 2023 04:51:44 +0800 [thread overview]
Message-ID: <20230305205144.14443-1-zobin1999@gmail.com> (raw)
v2:
* fix code format
Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes")
Cc: cunming.liang@intel.com
Signed-off-by: Zhuobin Huang <zobin1999@gmail.com>
---
...x-data-length-of-each-packet-segment.patch | 54 +++++++++++++++++++
app/test/packet_burst_generator.c | 2 +-
2 files changed, 55 insertions(+), 1 deletion(-)
create mode 100644 0001-app-test-fix-data-length-of-each-packet-segment.patch
diff --git a/0001-app-test-fix-data-length-of-each-packet-segment.patch b/0001-app-test-fix-data-length-of-each-packet-segment.patch
new file mode 100644
index 0000000000..aa52bb2ae2
--- /dev/null
+++ b/0001-app-test-fix-data-length-of-each-packet-segment.patch
@@ -0,0 +1,54 @@
+From 7b3827259bded81127fb33572868815bd53ad564 Mon Sep 17 00:00:00 2001
+From: Zhuobin Huang <zobin1999@gmail.com>
+Date: Mon, 6 Mar 2023 04:13:20 +0800
+Subject: [PATCH] app/test: fix data length of each packet segment
+
+Assign correct data length to each segments according
+to the given pkt_len and nb_pkt_segs, instead of
+using pkt_len as the data_len of every packet segment
+
+Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes")
+Cc: cunming.liang@intel.com
+
+Signed-off-by: Zhuobin Huang <zobin1999@gmail.com>
+---
+ app/test/packet_burst_generator.c | 9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c
+index 6b42b9b83b..c2e51a3bf1 100644
+--- a/app/test/packet_burst_generator.c
++++ b/app/test/packet_burst_generator.c
+@@ -350,6 +350,8 @@ generate_packet_burst_proto(struct rte_mempool *mp,
+ struct rte_mbuf *pkt_seg;
+ struct rte_mbuf *pkt;
+
++ const uint8_t pkt_seg_data_len = pkt_len / nb_pkt_segs;
++
+ for (nb_pkt = 0; nb_pkt < nb_pkt_per_burst; nb_pkt++) {
+ pkt = rte_pktmbuf_alloc(mp);
+ if (pkt == NULL) {
+@@ -359,7 +361,7 @@ generate_packet_burst_proto(struct rte_mempool *mp,
+ break;
+ }
+
+- pkt->data_len = pkt_len;
++ pkt->data_len = pkt_seg_data_len;
+ pkt_seg = pkt;
+ for (i = 1; i < nb_pkt_segs; i++) {
+ pkt_seg->next = rte_pktmbuf_alloc(mp);
+@@ -369,7 +371,10 @@ generate_packet_burst_proto(struct rte_mempool *mp,
+ goto nomore_mbuf;
+ }
+ pkt_seg = pkt_seg->next;
+- pkt_seg->data_len = pkt_len;
++ if(i != nb_pkt_segs - 1)
++ pkt_seg->data_len = pkt_seg_data_len;
++ else
++ pkt_seg->data_len = pkt_seg_data_len + pkt_len % nb_pkt_segs;
+ }
+ pkt_seg->next = NULL; /* Last segment of packet. */
+
+--
+2.34.1
+
diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c
index c2e51a3bf1..940f6ddde8 100644
--- a/app/test/packet_burst_generator.c
+++ b/app/test/packet_burst_generator.c
@@ -371,7 +371,7 @@ generate_packet_burst_proto(struct rte_mempool *mp,
goto nomore_mbuf;
}
pkt_seg = pkt_seg->next;
- if(i != nb_pkt_segs - 1)
+ if (i != nb_pkt_segs - 1)
pkt_seg->data_len = pkt_seg_data_len;
else
pkt_seg->data_len = pkt_seg_data_len + pkt_len % nb_pkt_segs;
--
2.34.1
reply other threads:[~2023-03-05 20:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230305205144.14443-1-zobin1999@gmail.com \
--to=zobin1999@gmail.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).