DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2] app/test: fix data length of each packet segment
@ 2023-03-05 20:51 Zhuobin Huang
  0 siblings, 0 replies; only message in thread
From: Zhuobin Huang @ 2023-03-05 20:51 UTC (permalink / raw)
  To: dev; +Cc: cunming.liang

v2: 
* fix code format

Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes")
Cc: cunming.liang@intel.com

Signed-off-by: Zhuobin Huang <zobin1999@gmail.com>
---
 ...x-data-length-of-each-packet-segment.patch | 54 +++++++++++++++++++
 app/test/packet_burst_generator.c             |  2 +-
 2 files changed, 55 insertions(+), 1 deletion(-)
 create mode 100644 0001-app-test-fix-data-length-of-each-packet-segment.patch

diff --git a/0001-app-test-fix-data-length-of-each-packet-segment.patch b/0001-app-test-fix-data-length-of-each-packet-segment.patch
new file mode 100644
index 0000000000..aa52bb2ae2
--- /dev/null
+++ b/0001-app-test-fix-data-length-of-each-packet-segment.patch
@@ -0,0 +1,54 @@
+From 7b3827259bded81127fb33572868815bd53ad564 Mon Sep 17 00:00:00 2001
+From: Zhuobin Huang <zobin1999@gmail.com>
+Date: Mon, 6 Mar 2023 04:13:20 +0800
+Subject: [PATCH] app/test: fix data length of each packet segment
+
+Assign correct data length to each segments according
+to the given pkt_len and nb_pkt_segs, instead of
+using pkt_len as the data_len of every packet segment
+
+Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes")
+Cc: cunming.liang@intel.com
+
+Signed-off-by: Zhuobin Huang <zobin1999@gmail.com>
+---
+ app/test/packet_burst_generator.c | 9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c
+index 6b42b9b83b..c2e51a3bf1 100644
+--- a/app/test/packet_burst_generator.c
++++ b/app/test/packet_burst_generator.c
+@@ -350,6 +350,8 @@ generate_packet_burst_proto(struct rte_mempool *mp,
+ 	struct rte_mbuf *pkt_seg;
+ 	struct rte_mbuf *pkt;
+ 
++	const uint8_t pkt_seg_data_len = pkt_len / nb_pkt_segs;
++
+ 	for (nb_pkt = 0; nb_pkt < nb_pkt_per_burst; nb_pkt++) {
+ 		pkt = rte_pktmbuf_alloc(mp);
+ 		if (pkt == NULL) {
+@@ -359,7 +361,7 @@ generate_packet_burst_proto(struct rte_mempool *mp,
+ 			break;
+ 		}
+ 
+-		pkt->data_len = pkt_len;
++		pkt->data_len = pkt_seg_data_len;
+ 		pkt_seg = pkt;
+ 		for (i = 1; i < nb_pkt_segs; i++) {
+ 			pkt_seg->next = rte_pktmbuf_alloc(mp);
+@@ -369,7 +371,10 @@ generate_packet_burst_proto(struct rte_mempool *mp,
+ 				goto nomore_mbuf;
+ 			}
+ 			pkt_seg = pkt_seg->next;
+-			pkt_seg->data_len = pkt_len;
++			if(i != nb_pkt_segs - 1)
++				pkt_seg->data_len = pkt_seg_data_len;
++			else
++				pkt_seg->data_len = pkt_seg_data_len + pkt_len % nb_pkt_segs;
+ 		}
+ 		pkt_seg->next = NULL; /* Last segment of packet. */
+ 
+-- 
+2.34.1
+
diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c
index c2e51a3bf1..940f6ddde8 100644
--- a/app/test/packet_burst_generator.c
+++ b/app/test/packet_burst_generator.c
@@ -371,7 +371,7 @@ generate_packet_burst_proto(struct rte_mempool *mp,
 				goto nomore_mbuf;
 			}
 			pkt_seg = pkt_seg->next;
-			if(i != nb_pkt_segs - 1)
+			if (i != nb_pkt_segs - 1)
 				pkt_seg->data_len = pkt_seg_data_len;
 			else
 				pkt_seg->data_len = pkt_seg_data_len + pkt_len % nb_pkt_segs;
-- 
2.34.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-05 20:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-05 20:51 [PATCH v2] app/test: fix data length of each packet segment Zhuobin Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).