* [PATCH 2/7] net/mlx5: fix the error set in quota init
@ 2023-06-30 5:48 Bing Zhao
0 siblings, 0 replies; only message in thread
From: Bing Zhao @ 2023-06-30 5:48 UTC (permalink / raw)
To: matan, viacheslavo, orika, suanmingm, rasland; +Cc: dev, getelson
When there was a failure in the quota initialization, only the
return value was set. The "rte_errno" and the "rte_flow_error"
were not set. The application may get a crash when trying to
access the "message" field.
Fixes: 15896eaf9d71 ("net/mlx5: support indirect quota create/query/modify")
Cc: getelson@nvidia.com
Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_hw.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index b5137a822a..ba2f1f7c92 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -7789,8 +7789,11 @@ flow_hw_configure(struct rte_eth_dev *dev,
/* Initialize quotas */
if (port_attr->nb_quotas) {
ret = mlx5_flow_quota_init(dev, port_attr->nb_quotas);
- if (ret)
+ if (ret) {
+ rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+ "Failed to initialize quota.");
goto err;
+ }
}
/* Initialize meter library*/
if (port_attr->nb_meters || (host_priv && host_priv->hws_mpool))
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-30 5:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30 5:48 [PATCH 2/7] net/mlx5: fix the error set in quota init Bing Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).