* [PATCH] net/iavf: fix avx2 path selection
@ 2023-07-06 3:15 Zhichao Zeng
0 siblings, 0 replies; 4+ messages in thread
From: Zhichao Zeng @ 2023-07-06 3:15 UTC (permalink / raw)
To: dev
Cc: qi.z.zhang, ke1.xu, Zhichao Zeng, Jingjing Wu, Beilei Xing, Wenzhuo Lu
The AVX2 path does not support outer checksum offload, when AVX2 is
forcibly selected and outer checksum offload is configured, the basic
Tx path will be selected to ensure proper functionality.
Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index bf7e4546a8..f7df4665d1 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -3950,6 +3950,12 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2;
PMD_DRV_LOG(DEBUG, "Using AVX2 Vector Tx (port %d).",
dev->data->port_id);
+ } else if (check_ret == IAVF_VECTOR_CTX_OFFLOAD_PATH) {
+ dev->tx_pkt_burst = iavf_xmit_pkts;
+ dev->tx_pkt_prepare = iavf_prep_pkts;
+ PMD_DRV_LOG(DEBUG,
+ "AVX2 does not support outer checksum offload, using Basic Tx (port %d).",
+ dev->data->port_id);
} else {
dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2_offload;
dev->tx_pkt_prepare = iavf_prep_pkts;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/iavf: fix AVX2 path selection
2023-07-06 3:52 ` Xu, Ke1
@ 2023-07-06 6:06 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2023-07-06 6:06 UTC (permalink / raw)
To: Xu, Ke1, Zeng, ZhichaoX, dev; +Cc: Wu, Jingjing, Xing, Beilei, Lu, Wenzhuo
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Thursday, July 6, 2023 11:52 AM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: RE: [PATCH] net/iavf: fix AVX2 path selection
>
>
> > -----Original Message-----
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Thursday, July 6, 2023 11:20 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ke1 <ke1.xu@intel.com>;
> > Zeng, ZhichaoX <zhichaox.zeng@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> > Wenzhuo <wenzhuo.lu@intel.com>
> > Subject: [PATCH] net/iavf: fix AVX2 path selection
> >
> > The AVX2 path does not support outer checksum offload, when AVX2 is
> > forcibly selected and outer checksum offload is configured, the basic
> > Tx path will be selected to ensure proper functionality.
> >
> > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> Verified path selection fixed.
> Tested-by: Ke Xu <ke1.xu@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/iavf: fix AVX2 path selection
2023-07-06 3:20 [PATCH] net/iavf: fix AVX2 " Zhichao Zeng
@ 2023-07-06 3:52 ` Xu, Ke1
2023-07-06 6:06 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Xu, Ke1 @ 2023-07-06 3:52 UTC (permalink / raw)
To: Zeng, ZhichaoX, dev; +Cc: Zhang, Qi Z, Wu, Jingjing, Xing, Beilei, Lu, Wenzhuo
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Thursday, July 6, 2023 11:20 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ke1 <ke1.xu@intel.com>;
> Zeng, ZhichaoX <zhichaox.zeng@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [PATCH] net/iavf: fix AVX2 path selection
>
> The AVX2 path does not support outer checksum offload, when AVX2 is
> forcibly selected and outer checksum offload is configured, the basic Tx
> path will be selected to ensure proper functionality.
>
> Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
Verified path selection fixed.
Tested-by: Ke Xu <ke1.xu@intel.com>
> ---
> drivers/net/iavf/iavf_rxtx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net/iavf: fix AVX2 path selection
@ 2023-07-06 3:20 Zhichao Zeng
2023-07-06 3:52 ` Xu, Ke1
0 siblings, 1 reply; 4+ messages in thread
From: Zhichao Zeng @ 2023-07-06 3:20 UTC (permalink / raw)
To: dev
Cc: qi.z.zhang, ke1.xu, Zhichao Zeng, Jingjing Wu, Beilei Xing, Wenzhuo Lu
The AVX2 path does not support outer checksum offload, when AVX2 is
forcibly selected and outer checksum offload is configured, the basic
Tx path will be selected to ensure proper functionality.
Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index bf7e4546a8..f7df4665d1 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -3950,6 +3950,12 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2;
PMD_DRV_LOG(DEBUG, "Using AVX2 Vector Tx (port %d).",
dev->data->port_id);
+ } else if (check_ret == IAVF_VECTOR_CTX_OFFLOAD_PATH) {
+ dev->tx_pkt_burst = iavf_xmit_pkts;
+ dev->tx_pkt_prepare = iavf_prep_pkts;
+ PMD_DRV_LOG(DEBUG,
+ "AVX2 does not support outer checksum offload, using Basic Tx (port %d).",
+ dev->data->port_id);
} else {
dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2_offload;
dev->tx_pkt_prepare = iavf_prep_pkts;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-06 6:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-06 3:15 [PATCH] net/iavf: fix avx2 path selection Zhichao Zeng
2023-07-06 3:20 [PATCH] net/iavf: fix AVX2 " Zhichao Zeng
2023-07-06 3:52 ` Xu, Ke1
2023-07-06 6:06 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).