* [PATCH 1/2] app/test: remove unnecessary null check before free
@ 2023-08-04 16:41 Stephen Hemminger
2023-08-04 16:41 ` [PATCH 2/2] net/bnxt: remove unnecessary check for null " Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2023-08-04 16:41 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Akhil Goyal, Fan Zhang, Konstantin Ananyev
No need to check for NULL pointer before calling these functions
Found by cocci/nullfree.cocci.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_cryptodev_asym.c | 3 +--
app/test/test_reassembly_perf.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 0ef2642fdd2b..c43a063b8262 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -565,8 +565,7 @@ ut_teardown_asym(void)
if (self->sess != NULL)
rte_cryptodev_asym_session_free(dev_id, self->sess);
- if (self->op != NULL)
- rte_crypto_op_free(self->op);
+ rte_crypto_op_free(self->op);
self->sess = NULL;
self->op = NULL;
self->result_op = NULL;
diff --git a/app/test/test_reassembly_perf.c b/app/test/test_reassembly_perf.c
index c11b65291fec..3af104b67348 100644
--- a/app/test/test_reassembly_perf.c
+++ b/app/test/test_reassembly_perf.c
@@ -81,8 +81,7 @@ reassembly_test_teardown(void)
if (frag_tbl != NULL)
rte_ip_frag_table_destroy(frag_tbl);
- if (pkt_pool != NULL)
- rte_mempool_free(pkt_pool);
+ rte_mempool_free(pkt_pool);
}
static void
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] net/bnxt: remove unnecessary check for null before free
2023-08-04 16:41 [PATCH 1/2] app/test: remove unnecessary null check before free Stephen Hemminger
@ 2023-08-04 16:41 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2023-08-04 16:41 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Ajit Khaparde, Somnath Kotur
No need to check for null pointer before calling rte_free().
Found by cocci/nullfree.cocci script.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_ethdev.c | 3 +--
drivers/net/bnxt/bnxt_vnic.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ee1552452a11..ec8e441a6d05 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -6002,8 +6002,7 @@ static void bnxt_free_ctx_mem_buf(struct bnxt_ctx_mem_buf_info *ctx)
if (!ctx)
return;
- if (ctx->va)
- rte_free(ctx->va);
+ rte_free(ctx->va);
ctx->va = NULL;
ctx->dma = RTE_BAD_IOVA;
diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c
index 2be456956ddc..f86d27fd7965 100644
--- a/drivers/net/bnxt/bnxt_vnic.c
+++ b/drivers/net/bnxt/bnxt_vnic.c
@@ -847,8 +847,7 @@ bnxt_vnic_rss_hash_algo_update(struct bnxt *bp,
int32_t bnxt_vnic_queue_db_deinit(struct bnxt *bp)
{
- if (bp->vnic_queue_db.rss_q_db != NULL)
- rte_hash_free(bp->vnic_queue_db.rss_q_db);
+ rte_hash_free(bp->vnic_queue_db.rss_q_db);
return 0;
}
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-04 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-04 16:41 [PATCH 1/2] app/test: remove unnecessary null check before free Stephen Hemminger
2023-08-04 16:41 ` [PATCH 2/2] net/bnxt: remove unnecessary check for null " Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).