* [PATCH] common/cnxk: explicitly clear aura bp ena on cleanup
@ 2023-08-22 17:30 Ashwin Sekhar T K
2023-08-24 12:16 ` Jerin Jacob
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ashwin Sekhar T K @ 2023-08-22 17:30 UTC (permalink / raw)
To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: jerinj, pbhagavatula, psatheesh, asekhar, anoobj, gakhil, hkalra
As done in FLR, similar to CQ disable, in process of
aura disable we needs explicitly clear BP_ENA in order to
deassert backpressure if it was earlier asserted.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
drivers/common/cnxk/roc_npa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
index 3b9a70028b..20801739dc 100644
--- a/drivers/common/cnxk/roc_npa.c
+++ b/drivers/common/cnxk/roc_npa.c
@@ -185,6 +185,8 @@ npa_aura_pool_fini(struct mbox *m_box, uint32_t aura_id, uint64_t aura_handle)
aura_req->op = NPA_AQ_INSTOP_WRITE;
aura_req->aura.ena = 0;
aura_req->aura_mask.ena = ~aura_req->aura_mask.ena;
+ aura_req->aura.bp_ena = 0;
+ aura_req->aura_mask.bp_ena = ~aura_req->aura_mask.bp_ena;
rc = mbox_process(mbox);
if (rc < 0)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] common/cnxk: explicitly clear aura bp ena on cleanup
2023-08-22 17:30 [PATCH] common/cnxk: explicitly clear aura bp ena on cleanup Ashwin Sekhar T K
@ 2023-08-24 12:16 ` Jerin Jacob
2023-08-25 3:53 ` [PATCH] common/cnxk: fix bp_ena clearing during pool tear down Ashwin Sekhar T K
2023-08-25 3:57 ` [PATCH v2] common/cnxk: fix bp_ena clear while disabling aura Ashwin Sekhar T K
2 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-08-24 12:16 UTC (permalink / raw)
To: Ashwin Sekhar T K
Cc: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, jerinj, pbhagavatula, psatheesh, anoobj, gakhil,
hkalra
On Tue, Aug 22, 2023 at 11:00 PM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
>
> As done in FLR, similar to CQ disable, in process of
> aura disable we needs explicitly clear BP_ENA in order to
> deassert backpressure if it was earlier asserted.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
Is n't fix? Please add Fixes tag and change subject to common/cnxk: fix ...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] common/cnxk: fix bp_ena clearing during pool tear down
2023-08-22 17:30 [PATCH] common/cnxk: explicitly clear aura bp ena on cleanup Ashwin Sekhar T K
2023-08-24 12:16 ` Jerin Jacob
@ 2023-08-25 3:53 ` Ashwin Sekhar T K
2023-08-25 3:57 ` [PATCH v2] common/cnxk: fix bp_ena clear while disabling aura Ashwin Sekhar T K
2 siblings, 0 replies; 5+ messages in thread
From: Ashwin Sekhar T K @ 2023-08-25 3:53 UTC (permalink / raw)
To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: jerinj, pbhagavatula, psatheesh, asekhar, anoobj, gakhil, hkalra
As done in FLR, similar to CQ disable, in process of
aura disable we need to explicitly clear BP_ENA in order to
deassert backpressure if it was earlier asserted.
Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
drivers/common/cnxk/roc_npa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
index 3b9a70028b..20801739dc 100644
--- a/drivers/common/cnxk/roc_npa.c
+++ b/drivers/common/cnxk/roc_npa.c
@@ -185,6 +185,8 @@ npa_aura_pool_fini(struct mbox *m_box, uint32_t aura_id, uint64_t aura_handle)
aura_req->op = NPA_AQ_INSTOP_WRITE;
aura_req->aura.ena = 0;
aura_req->aura_mask.ena = ~aura_req->aura_mask.ena;
+ aura_req->aura.bp_ena = 0;
+ aura_req->aura_mask.bp_ena = ~aura_req->aura_mask.bp_ena;
rc = mbox_process(mbox);
if (rc < 0)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] common/cnxk: fix bp_ena clear while disabling aura
2023-08-22 17:30 [PATCH] common/cnxk: explicitly clear aura bp ena on cleanup Ashwin Sekhar T K
2023-08-24 12:16 ` Jerin Jacob
2023-08-25 3:53 ` [PATCH] common/cnxk: fix bp_ena clearing during pool tear down Ashwin Sekhar T K
@ 2023-08-25 3:57 ` Ashwin Sekhar T K
2023-08-25 5:52 ` Jerin Jacob
2 siblings, 1 reply; 5+ messages in thread
From: Ashwin Sekhar T K @ 2023-08-25 3:57 UTC (permalink / raw)
To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: jerinj, pbhagavatula, psatheesh, asekhar, anoobj, gakhil, hkalra
As done in FLR, similar to CQ disable, in process of
aura disable we need to explicitly clear BP_ENA in order to
deassert backpressure if it was earlier asserted.
Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
drivers/common/cnxk/roc_npa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
index 3b9a70028b..20801739dc 100644
--- a/drivers/common/cnxk/roc_npa.c
+++ b/drivers/common/cnxk/roc_npa.c
@@ -185,6 +185,8 @@ npa_aura_pool_fini(struct mbox *m_box, uint32_t aura_id, uint64_t aura_handle)
aura_req->op = NPA_AQ_INSTOP_WRITE;
aura_req->aura.ena = 0;
aura_req->aura_mask.ena = ~aura_req->aura_mask.ena;
+ aura_req->aura.bp_ena = 0;
+ aura_req->aura_mask.bp_ena = ~aura_req->aura_mask.bp_ena;
rc = mbox_process(mbox);
if (rc < 0)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] common/cnxk: fix bp_ena clear while disabling aura
2023-08-25 3:57 ` [PATCH v2] common/cnxk: fix bp_ena clear while disabling aura Ashwin Sekhar T K
@ 2023-08-25 5:52 ` Jerin Jacob
0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-08-25 5:52 UTC (permalink / raw)
To: Ashwin Sekhar T K
Cc: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, jerinj, pbhagavatula, psatheesh, anoobj, gakhil,
hkalra
On Fri, Aug 25, 2023 at 9:27 AM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
>
> As done in FLR, similar to CQ disable, in process of
> aura disable we need to explicitly clear BP_ENA in order to
> deassert backpressure if it was earlier asserted.
>
> Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: fix aura disable handling
As done in FLR, similar to CQ disable, in process of
aura disable we need to explicitly clear BP_ENA in order to
deassert backpressure if it was earlier asserted.
Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
Cc: stable@dpdk.org
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-25 5:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-22 17:30 [PATCH] common/cnxk: explicitly clear aura bp ena on cleanup Ashwin Sekhar T K
2023-08-24 12:16 ` Jerin Jacob
2023-08-25 3:53 ` [PATCH] common/cnxk: fix bp_ena clearing during pool tear down Ashwin Sekhar T K
2023-08-25 3:57 ` [PATCH v2] common/cnxk: fix bp_ena clear while disabling aura Ashwin Sekhar T K
2023-08-25 5:52 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).