DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH] devtools: extend check on compiler builtin atomics
Date: Tue, 17 Oct 2023 04:34:29 -0700	[thread overview]
Message-ID: <20231017113429.GA23126@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20231017113125.2990147-1-david.marchand@redhat.com>

On Tue, Oct 17, 2023 at 01:31:25PM +0200, David Marchand wrote:
> rte_memory_order_* should be used when calling the new stdatomic API.
> Add a check on __ATOMIC_* tokens.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

>  devtools/checkpatches.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 2635923e14..7740152643 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -113,9 +113,9 @@ check_forbidden_additions() { # <patch>
>  
>  	# refrain from using compiler __atomic_xxx builtins
>  	awk -v FOLDERS="lib drivers app examples" \
> -		-v EXPRESSIONS="__atomic_.*\\\(" \
> +		-v EXPRESSIONS="__atomic_.*\\\( __ATOMIC_(RELAXED|CONSUME|ACQUIRE|RELEASE|ACQ_REL|SEQ_CST)" \
>  		-v RET_ON_FAIL=1 \
> -		-v MESSAGE='Using __atomic_xxx built-ins, prefer rte_atomic_xxx' \
> +		-v MESSAGE='Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx' \

Not sure if it should say prefer rte_atomic_xxx/rte_memory_order_xxx ?

Either way it catches the problem.


  reply	other threads:[~2023-10-17 11:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 11:31 David Marchand
2023-10-17 11:34 ` Tyler Retzlaff [this message]
2023-10-19  7:08   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017113429.GA23126@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).