From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH] devtools: extend check on compiler builtin atomics
Date: Thu, 19 Oct 2023 09:08:45 +0200 [thread overview]
Message-ID: <CAJFAV8z_aVd0Zk4+YtJ94BD5P0ZNbFXz=9RNrGFO8gq4yJbN_w@mail.gmail.com> (raw)
In-Reply-To: <20231017113429.GA23126@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Tue, Oct 17, 2023 at 1:34 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> On Tue, Oct 17, 2023 at 01:31:25PM +0200, David Marchand wrote:
> > rte_memory_order_* should be used when calling the new stdatomic API.
> > Add a check on __ATOMIC_* tokens.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
[snip]
> > -v RET_ON_FAIL=1 \
> > - -v MESSAGE='Using __atomic_xxx built-ins, prefer rte_atomic_xxx' \
> > + -v MESSAGE='Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx' \
>
> Not sure if it should say prefer rte_atomic_xxx/rte_memory_order_xxx ?
Looks ok to me, I did this small change while applying.
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2023-10-19 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 11:31 David Marchand
2023-10-17 11:34 ` Tyler Retzlaff
2023-10-19 7:08 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z_aVd0Zk4+YtJ94BD5P0ZNbFXz=9RNrGFO8gq4yJbN_w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).