* [PATCH] net/nfp: fix offload flags of the security capabilities
@ 2023-10-28 6:31 Chaoyong He
2023-11-01 17:23 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2023-10-28 6:31 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, Shihong Wang, stable, Chaoyong He, Peng Zhang
From: Shihong Wang <shihong.wang@corigine.com>
This patch resolves configuration error of ol_flags in the
rte_security_capability. Currently ol_flags in the ingress direction
of the SA, 'RTE_SECURITY_TX_OLOAD_NEED_MDATA' is configured. In fact,
ol_flags only in the egress direction of the SA needs to be configured.
Fixes: e6d69ea011c9 ("net/nfp: get security capabilities and session size")
Cc: stable@dpdk.org
Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/nfp_ipsec.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c
index a76ba2a91d..302962c58b 100644
--- a/drivers/net/nfp/nfp_ipsec.c
+++ b/drivers/net/nfp/nfp_ipsec.c
@@ -242,7 +242,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps
+ .crypto_capabilities = nfp_crypto_caps,
+ .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
},
{ /* IPsec Inline Crypto Tunnel Ingress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
@@ -257,8 +258,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps,
- .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+ .crypto_capabilities = nfp_crypto_caps
},
{ /* IPsec Inline Crypto Transport Egress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
@@ -273,7 +273,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps
+ .crypto_capabilities = nfp_crypto_caps,
+ .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
},
{ /* IPsec Inline Crypto Transport Ingress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
@@ -288,8 +289,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps,
- .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+ .crypto_capabilities = nfp_crypto_caps
},
{ /* IPsec Inline Protocol Tunnel Egress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -304,7 +304,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps
+ .crypto_capabilities = nfp_crypto_caps,
+ .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
},
{ /* IPsec Inline Protocol Tunnel Ingress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -319,8 +320,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps,
- .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+ .crypto_capabilities = nfp_crypto_caps
},
{ /* IPsec Inline Protocol Transport Egress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -335,7 +335,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps
+ .crypto_capabilities = nfp_crypto_caps,
+ .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
},
{ /* IPsec Inline Protocol Transport Ingress */
.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -350,8 +351,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
.esn = 1
}
},
- .crypto_capabilities = nfp_crypto_caps,
- .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+ .crypto_capabilities = nfp_crypto_caps
},
{
.action = RTE_SECURITY_ACTION_TYPE_NONE
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfp: fix offload flags of the security capabilities
2023-10-28 6:31 [PATCH] net/nfp: fix offload flags of the security capabilities Chaoyong He
@ 2023-11-01 17:23 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-11-01 17:23 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, Shihong Wang, stable, Peng Zhang
On 10/28/2023 7:31 AM, Chaoyong He wrote:
> From: Shihong Wang <shihong.wang@corigine.com>
>
> This patch resolves configuration error of ol_flags in the
> rte_security_capability. Currently ol_flags in the ingress direction
> of the SA, 'RTE_SECURITY_TX_OLOAD_NEED_MDATA' is configured. In fact,
> ol_flags only in the egress direction of the SA needs to be configured.
>
> Fixes: e6d69ea011c9 ("net/nfp: get security capabilities and session size")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-01 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-28 6:31 [PATCH] net/nfp: fix offload flags of the security capabilities Chaoyong He
2023-11-01 17:23 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).