DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] common/cnxk: fix link cfg for sdp
@ 2024-02-27 18:55 Harman Kalra
  2024-03-01 12:44 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Harman Kalra @ 2024-02-27 18:55 UTC (permalink / raw)
  To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
  Cc: dev, Harman Kalra

Link configure registers are invalid and should not be accessed
for SDP ports. But while on txq release which does SQ flush calls
backpressure disable API which configures these link registers.

Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames")

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 drivers/common/cnxk/roc_nix_tm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c
index 6a61e448a1..4e6a28f827 100644
--- a/drivers/common/cnxk/roc_nix_tm.c
+++ b/drivers/common/cnxk/roc_nix_tm.c
@@ -328,6 +328,9 @@ nix_tm_bp_config_set(struct roc_nix *roc_nix, uint16_t sq, uint16_t tc,
 	uint8_t k = 0;
 	int rc = 0, i;
 
+	if (roc_nix_is_sdp(roc_nix))
+		return 0;
+
 	sq_s = nix->sqs[sq];
 	if (!sq_s)
 		return -ENOENT;
-- 
2.18.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] common/cnxk: fix link cfg for sdp
  2024-02-27 18:55 [PATCH] common/cnxk: fix link cfg for sdp Harman Kalra
@ 2024-03-01 12:44 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2024-03-01 12:44 UTC (permalink / raw)
  To: Harman Kalra
  Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, dev

On Wed, Feb 28, 2024 at 12:25 AM Harman Kalra <hkalra@marvell.com> wrote:
>
> Link configure registers are invalid and should not be accessed
> for SDP ports. But while on txq release which does SQ flush calls
> backpressure disable API which configures these link registers.
>
> Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames")
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>

Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-main. Thanks


    common/cnxk: fix link config for SDP

    Link configure registers are invalid and should not be accessed
    for SDP ports. But while on Txq release which does SQ flush calls
    back pressure disable API which configures these link registers.

    Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames")
    Cc: stable@dpdk.org

    Signed-off-by: Harman Kalra <hkalra@marvell.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-01 12:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 18:55 [PATCH] common/cnxk: fix link cfg for sdp Harman Kalra
2024-03-01 12:44 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).