From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
To: dev@dpdk.org
Cc: gakhil@marvell.com, ciara.power@intel.com,
Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [PATCH v2] app/crypto-perf-test: fix unset crc algorithm
Date: Fri, 15 Mar 2024 10:44:34 +0000 [thread overview]
Message-ID: <20240315104434.2531-1-arkadiuszx.kusztal@intel.com> (raw)
In-Reply-To: <20240313145448.26264-1-arkadiuszx.kusztal@intel.com>
Because net crc api is not thread-safe, setting crc algorithm
by the application will prevent race condition in the calc function.
Race condition still may occur when any of the threads will call this
function again. Function is called with the highest possible SIMD
extension, which is AVX512, but if this is not found, CRC API will
pick the other highest possible extension, or scalar if no SIMD
available.
Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
---
v2:
- narrowed down the case to the docsis only
app/test-crypto-perf/main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 40c0b4b54f..1b23dd5fb2 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -11,6 +11,7 @@
#include <rte_eal.h>
#include <rte_errno.h>
#include <rte_cryptodev.h>
+#include <rte_net_crc.h>
#ifdef RTE_CRYPTO_SCHEDULER
#include <rte_cryptodev_scheduler.h>
#endif
@@ -599,6 +600,9 @@ main(int argc, char **argv)
goto err;
}
+ if (opts.op_type == CPERF_DOCSIS)
+ rte_net_crc_set_alg(RTE_NET_CRC_AVX512);
+
ret = cperf_verify_devices_capabilities(&opts, enabled_cdevs,
nb_cryptodevs);
if (ret) {
--
2.13.6
next prev parent reply other threads:[~2024-03-15 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 14:54 [PATCH] " Arkadiusz Kusztal
2024-03-13 18:22 ` [EXTERNAL] " Akhil Goyal
2024-03-13 22:15 ` Kusztal, ArkadiuszX
2024-03-14 12:49 ` Akhil Goyal
2024-03-15 9:56 ` Kusztal, ArkadiuszX
2024-03-15 10:44 ` Arkadiusz Kusztal [this message]
2024-03-15 10:49 ` [PATCH v2] " Power, Ciara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315104434.2531-1-arkadiuszx.kusztal@intel.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).