DPDK patches and discussions
 help / color / mirror / Atom feed
From: Robin Jarry <rjarry@redhat.com>
To: dev@dpdk.org, Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] telemetry: lower log level when legacy is not configured
Date: Fri,  5 Jul 2024 11:00:20 +0200	[thread overview]
Message-ID: <20240705090020.481903-2-rjarry@redhat.com> (raw)

When starting any DPDK application, this warning log is displayed:

 TELEMETRY: No legacy callbacks, legacy socket not created

This brings unnecessary attention, lower the log level to DEBUG.

Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 doc/guides/contributing/unit_test.rst | 1 -
 doc/guides/nics/cnxk.rst              | 1 -
 lib/telemetry/telemetry.c             | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/doc/guides/contributing/unit_test.rst b/doc/guides/contributing/unit_test.rst
index 063cefa192ae..c0f0d2988f00 100644
--- a/doc/guides/contributing/unit_test.rst
+++ b/doc/guides/contributing/unit_test.rst
@@ -98,7 +98,6 @@ The unit test app can accept test suite names via command line arguments::
    EAL: Detected static linkage of DPDK
    EAL: Multi-process socket /run/user/26934/dpdk/rte/mp_socket
    EAL: Selected IOVA mode 'VA'
-   TELEMETRY: No legacy callbacks, legacy socket not created
    APP: HPET is not enabled, using TSC as default timer
    RTE>>version_autotest
    Version string: 'DPDK 21.08.0-rc0'
diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst
index dcb158385a29..ff380c10e905 100644
--- a/doc/guides/nics/cnxk.rst
+++ b/doc/guides/nics/cnxk.rst
@@ -76,7 +76,6 @@ for details.
       [ 2003.202721] vfio-pci 0002:02:00.0: vfio_cap_init: hiding cap 0x14@0x98
       EAL: Probe PCI driver: net_cn10k (177d:a063) device: 0002:02:00.0 (socket 0)
       PMD: RoC Model: cn10k
-      EAL: No legacy callbacks, legacy socket not created
       testpmd: create a new mbuf pool <mb_pool_0>: n=155456, size=2176, socket=0
       testpmd: preferred mempool ops selected: cn10k_mempool_ops
       Configuring Port 0 (socket 0)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 509fae76ec6d..c4c5a61a5cf8 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -541,7 +541,7 @@ telemetry_legacy_init(void)
 	int rc;
 
 	if (num_legacy_callbacks == 1) {
-		TMTY_LOG_LINE(WARNING, "No legacy callbacks, legacy socket not created");
+		TMTY_LOG_LINE(DEBUG, "No legacy callbacks, legacy socket not created");
 		return -1;
 	}
 
-- 
2.45.2


             reply	other threads:[~2024-07-05  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  9:00 Robin Jarry [this message]
2024-07-05  9:05 ` Bruce Richardson
2024-07-09  4:51   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705090020.481903-2-rjarry@redhat.com \
    --to=rjarry@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).