DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>, techboard@dpdk.org
Cc: dev@dpdk.org, jingjing.wu@intel.com, helin.zhang@intel.com,
	ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF
Date: Thu, 16 Mar 2017 17:03:31 +0100	[thread overview]
Message-ID: <2062537.uIRGRt8aVp@xps13> (raw)
In-Reply-To: <1487874421-11934-1-git-send-email-qi.z.zhang@intel.com>

2017-02-23 13:27, Qi Zhang:
>  static void
> +i40evf_dev_stats_reset(struct rte_eth_dev *dev)
> +{
> +	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
> +	/* only DPDK PF support this */
> +	if (vf->version_major == I40E_DPDK_VERSION_MAJOR) {
> +		if (i40evf_reset_statistics(dev))
> +			PMD_DRV_LOG(ERR, "Reset statistics failed");
> +	}
> +}

One more SR-IOV feature not supported with a Linux PF.
The basic stats feature must be marked as partially supported in
	doc/guides/nics/features/i40e_vf.ini
See also this email:
	http://dpdk.org/ml/archives/dev/2017-March/060063.html

I wonder whether we should allow such divergence between PF
implementations. Intel committed to avoid such fragmentation
and keep the SR-IOV messaging standard but it does not happen.
It is said that we must allow fast innovation in DPDK space.
I agree but we should also target a good usability of the VF drivers,
allowing to replace the PF implementations as needed.

Here is my suggestion: let's accept a VF feature only if the PF support
is submitted to both dpdk.org and kernel.org mailing lists.
I ask to add this topic to the next techboard meeting.

  reply	other threads:[~2017-03-16 16:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 18:27 Qi Zhang
2017-03-16 16:03 ` Thomas Monjalon [this message]
2017-03-17  2:06   ` Zhang, Qi Z
2017-03-17  3:28   ` Zhang, Helin
2017-03-17  8:02     ` Thomas Monjalon
2017-03-17  9:45       ` Zhang, Helin
2017-03-17 10:15         ` Thomas Monjalon
2017-03-17 20:14           ` Vincent Jardin
2017-03-17 23:03             ` Thomas Monjalon
2017-03-18 10:34               ` Vincent Jardin
2017-03-20  2:47           ` Zhang, Helin
2017-03-20  9:14             ` Thomas Monjalon
2017-03-22  9:48               ` Zhang, Helin
2017-04-01  0:50 ` Zhang, Helin
     [not found]   ` <039ED4275CED7440929022BC67E706115307CC65@SHSMSX103.ccr.corp.intel.com>
2017-04-12 11:19     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2062537.uIRGRt8aVp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).