From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Tal Shnaiderman <talshn@nvidia.com>,
stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tal Shnaiderman <talshn@mellanox.com>,
William Tu <u9012063@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] build: propagate Windows system dependencies to pkg-config
Date: Tue, 14 Sep 2021 15:59:39 +0200 [thread overview]
Message-ID: <2135018.IyJTUgjS8Y@thomas> (raw)
In-Reply-To: <CALDO+Sb_L4VhD3h4=-K=BsLHc=1E7df6CjL2uVH5wnrS8SxKXA@mail.gmail.com>
20/08/2021 18:08, William Tu:
> On Thu, Aug 19, 2021 at 4:15 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> > Windows EAL depends on some system libraries. They were linked using
> > add_project_link_arguments('-l<LIB>'), which prevented meson from adding
> > them to Libs.private of pkg-config file. As a result, applications using
> > pkg-config to find DPDK hit link errors, for example:
> >
> > librte_eal.a(eal_windows_eal_debug.c.obj) : error LNK2019: unresolved
> > external symbol __imp_SymInitialize referenced in function
> > rte_dump_stack
> >
> > Reference required libraries in EAL using ext_deps meson variable.
> > bus/pci and net/pcap depend on lib/eal and will pull them automatically.
> > Drop advapi32 dependency, as MinGW locates VirtualAlloc2() dynamically.
> >
> > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> > Fixes: c91717eb75c8 ("eal/windows: support exit and panic")
> > Cc: talshn@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Reported-by: William Tu <u9012063@gmail.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
>
> Thanks for the fix.
> I've tested on my Windows environment and it works ok.
> the libdpdk.pc shows the required libraries.
>
> Acked-by: William Tu <u9012063@gmail.com>
Converted to Tested-by.
Applied, thanks
prev parent reply other threads:[~2021-09-14 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 23:14 Dmitry Kozlyuk
2021-08-20 16:08 ` William Tu
2021-09-14 13:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2135018.IyJTUgjS8Y@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@mellanox.com \
--cc=talshn@nvidia.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).