* [PATCH] mldev: disable build on Windows
@ 2023-03-10 9:07 David Marchand
2023-03-10 9:18 ` Thomas Monjalon
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: David Marchand @ 2023-03-10 9:07 UTC (permalink / raw)
To: dev, thomas; +Cc: Srikanth Yalavarthi
Caught by UNH lab, Windows compilation is broken because of symbol
exports:
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_bfloat16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_bfloat16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_float16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_int16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_int8
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_uint16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_uint8
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_int16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_int8_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_uint16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_uint8_to_float32
Disable Windows build until this is fixed.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/mldev/meson.build | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build
index 23d108617d..42ee309870 100644
--- a/lib/mldev/meson.build
+++ b/lib/mldev/meson.build
@@ -1,6 +1,10 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright (c) 2022 Marvell.
+if is_windows
+ subdir_done()
+endif
+
sources = files(
'rte_mldev_pmd.c',
'rte_mldev.c',
--
2.39.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mldev: disable build on Windows
2023-03-10 9:07 [PATCH] mldev: disable build on Windows David Marchand
@ 2023-03-10 9:18 ` Thomas Monjalon
2023-03-10 9:19 ` David Marchand
2023-03-10 9:23 ` [PATCH v2] " David Marchand
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
2 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2023-03-10 9:18 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Srikanth Yalavarthi
The build breaks because of the weak symbols, so we can define this cause:
Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
10/03/2023 10:07, David Marchand:
> --- a/lib/mldev/meson.build
> +++ b/lib/mldev/meson.build
> +if is_windows
> + subdir_done()
> +endif
More complete handling:
if is_windows
build = false
reason = 'not supported on Windows'
subdir_done()
endif
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mldev: disable build on Windows
2023-03-10 9:18 ` Thomas Monjalon
@ 2023-03-10 9:19 ` David Marchand
0 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2023-03-10 9:19 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Srikanth Yalavarthi
On Fri, Mar 10, 2023 at 10:18 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The build breaks because of the weak symbols, so we can define this cause:
>
> Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
I was not 100% sure but it seems the best one yes.
>
> 10/03/2023 10:07, David Marchand:
> > --- a/lib/mldev/meson.build
> > +++ b/lib/mldev/meson.build
> > +if is_windows
> > + subdir_done()
> > +endif
>
> More complete handling:
>
> if is_windows
> build = false
> reason = 'not supported on Windows'
> subdir_done()
> endif
Indeed... v2 in progress.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] mldev: disable build on Windows
2023-03-10 9:07 [PATCH] mldev: disable build on Windows David Marchand
2023-03-10 9:18 ` Thomas Monjalon
@ 2023-03-10 9:23 ` David Marchand
2023-03-10 9:32 ` Thomas Monjalon
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
2 siblings, 1 reply; 9+ messages in thread
From: David Marchand @ 2023-03-10 9:23 UTC (permalink / raw)
To: dev, thomas; +Cc: Srikanth Yalavarthi
Caught by UNH lab, Windows compilation is broken because of symbol
exports:
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_bfloat16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_bfloat16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_float16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_int16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_int8
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_uint16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_float32_to_uint8
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_int16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_int8_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_uint16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
rte_ml_io_uint8_to_float32
Disable Windows build until this is fixed.
Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/mldev/meson.build | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build
index 23d108617d..51ba809465 100644
--- a/lib/mldev/meson.build
+++ b/lib/mldev/meson.build
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright (c) 2022 Marvell.
+if is_windows
+ build = false
+ reason = 'not supported on Windows'
+ subdir_done()
+endif
+
sources = files(
'rte_mldev_pmd.c',
'rte_mldev.c',
--
2.39.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] mldev: disable build on Windows
2023-03-10 9:23 ` [PATCH v2] " David Marchand
@ 2023-03-10 9:32 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2023-03-10 9:32 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Srikanth Yalavarthi
10/03/2023 10:23, David Marchand:
> Caught by UNH lab, Windows compilation is broken because of symbol
> exports:
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_bfloat16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_bfloat16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_float16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_int16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_int8
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_uint16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_uint8
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_int16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_int8_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_uint16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_uint8_to_float32
>
> Disable Windows build until this is fixed.
>
> Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mldev: disable build on Windows
2023-03-10 9:07 [PATCH] mldev: disable build on Windows David Marchand
2023-03-10 9:18 ` Thomas Monjalon
2023-03-10 9:23 ` [PATCH v2] " David Marchand
@ 2023-03-10 20:06 ` Tyler Retzlaff
2023-03-10 22:54 ` Stephen Hemminger
2 siblings, 1 reply; 9+ messages in thread
From: Tyler Retzlaff @ 2023-03-10 20:06 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, Srikanth Yalavarthi
On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote:
> Caught by UNH lab, Windows compilation is broken because of symbol
> exports:
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_bfloat16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_bfloat16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_float16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_int16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_int8
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_uint16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_float32_to_uint8
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_int16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_int8_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_uint16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> rte_ml_io_uint8_to_float32
>
> Disable Windows build until this is fixed.
is someone committed to do this?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mldev: disable build on Windows
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
@ 2023-03-10 22:54 ` Stephen Hemminger
2023-03-11 8:11 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2023-03-10 22:54 UTC (permalink / raw)
To: Tyler Retzlaff; +Cc: David Marchand, dev, thomas, Srikanth Yalavarthi
On Fri, 10 Mar 2023 12:06:35 -0800
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote:
> > Caught by UNH lab, Windows compilation is broken because of symbol
> > exports:
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_bfloat16_to_float32
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float16_to_float32
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float32_to_bfloat16
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float32_to_float16
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float32_to_int16
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float32_to_int8
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float32_to_uint16
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_float32_to_uint8
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_int16_to_float32
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_int8_to_float32
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_uint16_to_float32
> > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > rte_ml_io_uint8_to_float32
> >
> > Disable Windows build until this is fixed.
>
> is someone committed to do this?
>
This is not hard to fix, please fix the Windows build rather than disabling.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mldev: disable build on Windows
2023-03-10 22:54 ` Stephen Hemminger
@ 2023-03-11 8:11 ` Thomas Monjalon
2023-03-11 14:53 ` [EXT] " Srikanth Yalavarthi
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2023-03-11 8:11 UTC (permalink / raw)
To: Tyler Retzlaff, Stephen Hemminger
Cc: dev, David Marchand, dev, Srikanth Yalavarthi
10/03/2023 23:54, Stephen Hemminger:
> On Fri, 10 Mar 2023 12:06:35 -0800
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote:
> > > Caught by UNH lab, Windows compilation is broken because of symbol
> > > exports:
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_bfloat16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_bfloat16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_float16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_int16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_int8
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_uint16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_uint8
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_int16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_int8_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_uint16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_uint8_to_float32
> > >
> > > Disable Windows build until this is fixed.
> >
> > is someone committed to do this?
>
> This is not hard to fix, please fix the Windows build rather than disabling.
I think we may need to change how the NEON implementation is selected,
without using weak references.
Feel free to submit a patch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [EXT] Re: [PATCH] mldev: disable build on Windows
2023-03-11 8:11 ` Thomas Monjalon
@ 2023-03-11 14:53 ` Srikanth Yalavarthi
0 siblings, 0 replies; 9+ messages in thread
From: Srikanth Yalavarthi @ 2023-03-11 14:53 UTC (permalink / raw)
To: Thomas Monjalon, Tyler Retzlaff, Stephen Hemminger
Cc: dev, David Marchand, dev, Srikanth Yalavarthi
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: 11 March 2023 13:42
> To: Tyler Retzlaff <roretzla@linux.microsoft.com>; Stephen Hemminger
> <stephen@networkplumber.org>
> Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com>;
> dev@dpdk.org; Srikanth Yalavarthi <syalavarthi@marvell.com>
> Subject: [EXT] Re: [PATCH] mldev: disable build on Windows
>
> External Email
>
> ----------------------------------------------------------------------
> 10/03/2023 23:54, Stephen Hemminger:
> > On Fri, 10 Mar 2023 12:06:35 -0800
> > Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> >
> > > On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote:
> > > > Caught by UNH lab, Windows compilation is broken because of symbol
> > > > exports:
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_bfloat16_to_float32
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float16_to_float32
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float32_to_bfloat16
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float32_to_float16
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float32_to_int16
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float32_to_int8
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float32_to_uint16
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_float32_to_uint8
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_int16_to_float32
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_int8_to_float32
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_uint16_to_float32
> > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > > rte_ml_io_uint8_to_float32
> > > >
> > > > Disable Windows build until this is fixed.
> > >
> > > is someone committed to do this?
> >
> > This is not hard to fix, please fix the Windows build rather than disabling.
>
> I think we may need to change how the NEON implementation is selected,
> without using weak references.
>
> Feel free to submit a patch.
>
I have submitted a patch to remove weak symbols and enable windows build. I could run windows build with MinGW-w64, but not a native build.
http://patches.dpdk.org/project/dpdk/patch/20230311145056.16386-1-syalavarthi@marvell.com/
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-11 14:53 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 9:07 [PATCH] mldev: disable build on Windows David Marchand
2023-03-10 9:18 ` Thomas Monjalon
2023-03-10 9:19 ` David Marchand
2023-03-10 9:23 ` [PATCH v2] " David Marchand
2023-03-10 9:32 ` Thomas Monjalon
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
2023-03-10 22:54 ` Stephen Hemminger
2023-03-11 8:11 ` Thomas Monjalon
2023-03-11 14:53 ` [EXT] " Srikanth Yalavarthi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).