DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] regex/mlx5: correct value written to doorbell db rec
@ 2023-02-21  7:49 Gerry Gribbon
  2023-03-10 18:09 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Gerry Gribbon @ 2023-02-21  7:49 UTC (permalink / raw)
  To: dev; +Cc: stable, Ori Kam

We were writing a value that should represent the number of items to be
processed by hardware. The value being written was off by 1 (N*4)+3;
The value should be (N*4) + 4 simplified to (N+1)*4

Fixes: 5dfa003db53f ("common/mlx5: fix post doorbell barrier")
Cc: stable@dpdk.org

Signed-off-by: Gerry Gribbon <ggribbon@nvidia.com>
---
 drivers/regex/mlx5/mlx5_regex_fastpath.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c b/drivers/regex/mlx5/mlx5_regex_fastpath.c
index 143c7d7cdf..822370be83 100644
--- a/drivers/regex/mlx5/mlx5_regex_fastpath.c
+++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c
@@ -211,8 +211,8 @@ send_doorbell(struct mlx5_regex_priv *priv, struct mlx5_regex_hw_qp *qp)
 			    (MLX5_SEND_WQE_BB << (priv->has_umr ? 2 : 0)) +
 			    (priv->has_umr ? MLX5_REGEX_UMR_WQE_SIZE : 0);
 	uint8_t *wqe = (uint8_t *)(uintptr_t)qp->qp_obj.wqes + wqe_offset;
-	uint32_t actual_pi = (priv->has_umr ? (qp->db_pi * 4 + 3) : qp->db_pi) &
-			     MLX5_REGEX_MAX_WQE_INDEX;
+	uint32_t actual_pi = (priv->has_umr ? ((1 + qp->db_pi) * 4) : qp->db_pi)
+			     & MLX5_REGEX_MAX_WQE_INDEX;
 
 	/* Or the fm_ce_se instead of set, avoid the fence be cleared. */
 	((struct mlx5_wqe_ctrl_seg *)wqe)->fm_ce_se |= MLX5_WQE_CTRL_CQ_UPDATE;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regex/mlx5: correct value written to doorbell db rec
  2023-02-21  7:49 [PATCH] regex/mlx5: correct value written to doorbell db rec Gerry Gribbon
@ 2023-03-10 18:09 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2023-03-10 18:09 UTC (permalink / raw)
  To: Gerry Gribbon; +Cc: dev, stable, Ori Kam

21/02/2023 08:49, Gerry Gribbon:
> We were writing a value that should represent the number of items to be
> processed by hardware. The value being written was off by 1 (N*4)+3;
> The value should be (N*4) + 4 simplified to (N+1)*4
> 
> Fixes: 5dfa003db53f ("common/mlx5: fix post doorbell barrier")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gerry Gribbon <ggribbon@nvidia.com>

Applied, thanks.

Note: better to say "doorbell record" instead of "db rec".




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-10 18:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21  7:49 [PATCH] regex/mlx5: correct value written to doorbell db rec Gerry Gribbon
2023-03-10 18:09 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).