DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] common/sfc_efx/base: update fields name for MARK and FLAG actions
@ 2023-05-31  7:08 Artemii Morozov
  2023-06-01 15:43 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Artemii Morozov @ 2023-05-31  7:08 UTC (permalink / raw)
  To: dev; +Cc: Andy Moreton, Andrew Rybchenko

The MCDI headers have newer, but ABI-compatible field names for
these actions.

Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
 drivers/common/sfc_efx/base/ef10_filter.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c
index 6d19797d16..d6940011c0 100644
--- a/drivers/common/sfc_efx/base/ef10_filter.c
+++ b/drivers/common/sfc_efx/base/ef10_filter.c
@@ -329,13 +329,13 @@ efx_mcdi_filter_op_add(
 		goto fail3;
 	}
 	if (spec->efs_flags & EFX_FILTER_FLAG_ACTION_MARK) {
-		MCDI_IN_SET_DWORD(req, FILTER_OP_V3_IN_MATCH_ACTION,
-		    MC_CMD_FILTER_OP_V3_IN_MATCH_ACTION_MARK);
+		MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS,
+		    FILTER_OP_V3_IN_MATCH_SET_MARK, 1);
 		MCDI_IN_SET_DWORD(req, FILTER_OP_V3_IN_MATCH_MARK_VALUE,
 		    spec->efs_mark);
 	} else if (spec->efs_flags & EFX_FILTER_FLAG_ACTION_FLAG) {
-		MCDI_IN_SET_DWORD(req, FILTER_OP_V3_IN_MATCH_ACTION,
-		    MC_CMD_FILTER_OP_V3_IN_MATCH_ACTION_FLAG);
+		MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS,
+		    FILTER_OP_V3_IN_MATCH_SET_FLAG, 1);
 	}
 
 	efx_mcdi_execute(enp, &req);
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] common/sfc_efx/base: update fields name for MARK and FLAG actions
  2023-05-31  7:08 [PATCH] common/sfc_efx/base: update fields name for MARK and FLAG actions Artemii Morozov
@ 2023-06-01 15:43 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-06-01 15:43 UTC (permalink / raw)
  To: Artemii Morozov, dev; +Cc: Andy Moreton, Andrew Rybchenko

On 5/31/2023 8:08 AM, Artemii Morozov wrote:
> The MCDI headers have newer, but ABI-compatible field names for
> these actions.
> 
> Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-01 15:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31  7:08 [PATCH] common/sfc_efx/base: update fields name for MARK and FLAG actions Artemii Morozov
2023-06-01 15:43 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).