* [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library
@ 2020-01-20 11:05 Thomas Monjalon
2020-01-20 11:06 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2020-01-20 11:05 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Mahipal Challa, Gavin Hu
The version of the PMD should not be overwritten with LIBABIVER.
All internal libs must have the same version.
Moreover, specifying LIBABIVER in the driver causes a symbolic link loop:
librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1
Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe")
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/raw/octeontx2_ep/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/raw/octeontx2_ep/Makefile b/drivers/raw/octeontx2_ep/Makefile
index 44fdf89599..1a54bf56f0 100644
--- a/drivers/raw/octeontx2_ep/Makefile
+++ b/drivers/raw/octeontx2_ep/Makefile
@@ -30,8 +30,6 @@ endif
EXPORT_MAP := rte_rawdev_octeontx2_ep_version.map
-LIBABIVER := 1
-
#
# All source are stored in SRCS-y
#
--
2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library
2020-01-20 11:05 [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library Thomas Monjalon
@ 2020-01-20 11:06 ` Ferruh Yigit
2020-01-20 11:44 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2020-01-20 11:06 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: Mahipal Challa, Gavin Hu
On 1/20/2020 11:05 AM, Thomas Monjalon wrote:
> The version of the PMD should not be overwritten with LIBABIVER.
> All internal libs must have the same version.
>
> Moreover, specifying LIBABIVER in the driver causes a symbolic link loop:
> librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1
>
> Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library
2020-01-20 11:06 ` Ferruh Yigit
@ 2020-01-20 11:44 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-01-20 11:44 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Mahipal Challa, Gavin Hu
20/01/2020 12:06, Ferruh Yigit:
> On 1/20/2020 11:05 AM, Thomas Monjalon wrote:
> > The version of the PMD should not be overwritten with LIBABIVER.
> > All internal libs must have the same version.
> >
> > Moreover, specifying LIBABIVER in the driver causes a symbolic link loop:
> > librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1
> >
> > Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe")
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks Ferruh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20 11:05 [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library Thomas Monjalon
2020-01-20 11:06 ` Ferruh Yigit
2020-01-20 11:44 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).