From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Simei Su <simei.su@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jian Wang <jianwang@trustnetic.com>,
david.marchand@redhat.com,
Olivier MATZ <olivier.matz@dev.6wind.com>
Subject: Re: [PATCH] drivers: remove compile-time option for IEEE 1588
Date: Thu, 02 Nov 2023 23:17:32 +0100 [thread overview]
Message-ID: <3062773.CbtlEUcBR6@thomas> (raw)
In-Reply-To: <CACZ4nhu1PyKONpAFsRQnea_FY80dbkVM+sgrTKjWQoNme1ca6w@mail.gmail.com>
02/11/2023 22:21, Ajit Khaparde:
> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> > On 6/25/2023 4:45 PM, Thomas Monjalon wrote:
> > > 23/06/2023 16:00, Ferruh Yigit:
> > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote:
> > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library
> > >>> unlike its name.
> > >>>
> > >>> Also we are suppose to enable/disable features dynamically,
> > >>> not at compilation time.
> > >>>
> > >>> And the best is that this macro is neither documented,
> > >>> nor in rte_config.h.
> > >>>
> > >>> It looks to be a mistake keeping this flag, so it is removed,
> > >>> meaning always enabled.
> > >>> PS: it is disabling vector paths of some drivers.
> > >>>
> > >>
> > >> PTP (IEEE1588) processing brings additional overhead to datapath.
> > >>
> > >> Agree that it is not good to have undocumented compile macro, but just
> > >> removing it may cause performance degradation.
> > >>
> > >> It may be possible to have separate burst function that supports PTP and
> > >> driver configures it when application explicitly request it with a new
> > >> offload flag (although it is not exactly an offload), what do you think?
> > >
> > > The best is to enable dynamically with different functions.
> >
> > There was no comment from driver maintainers.
If I made a baby when sending this patch, it would be a birth today.
Isn't it enough time to warn maintainers?
> > Perhaps better option is plan flag removal and execute it, like to
> > remove the flag in 24.11 LTS, this gives enough time for drivers to update.
You want to give time for one more baby?
> > If this sounds good, I can send a deprecation notice to record this plan.
> +1
Which plan? 2 babies?
next prev parent reply other threads:[~2023-11-02 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:28 Thomas Monjalon
2023-06-23 14:00 ` Ferruh Yigit
2023-06-25 15:45 ` Thomas Monjalon
2023-11-02 21:13 ` Ferruh Yigit
2023-11-02 21:21 ` Ajit Khaparde
2023-11-02 22:17 ` Thomas Monjalon [this message]
2023-11-03 0:08 ` Ferruh Yigit
2024-04-17 13:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3062773.CbtlEUcBR6@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=hemant.agrawal@nxp.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=olivier.matz@dev.6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=sachin.saxena@nxp.com \
--cc=simei.su@intel.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=wenjun1.wu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).