From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com,
david.marchand@redhat.com
Subject: Re: [PATCH] doc/power: add info on scale mode reaction time
Date: Fri, 26 Nov 2021 14:23:35 +0100 [thread overview]
Message-ID: <3358423.LUpCnhhR32@thomas> (raw)
In-Reply-To: <20211124165300.31165-1-david.hunt@intel.com>
24/11/2021 17:53, David Hunt:
> When using PMD Power Management, scale mode reacts slower than
> monitor mode and pause mode. Add note in user guide to this
> effect.
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> This power saving scheme will use ``librte_power`` library functionality to
> - scale the core frequency up/down depending on traffic volume.
> + scale the core frequency up/down depending on traffic volume. The reaction
> + time of the frequency scaling mode is longer than the pause and monitor
> + mode.
[...]
> - This will use frequency scaling routines
> - available in the ``librte_power`` library.
> + This will use frequency scaling routines available in
> + the ``librte_power`` library. The reaction time of the
> + scale mode is longer than the pause and monitor mode.
You don't have to change existing lines to add a new sentence.
That's why I recommend always starting a new sentence on a new line.
I fixed it to make the patch cleaner.
Applied
prev parent reply other threads:[~2021-11-26 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 16:53 David Hunt
2021-11-26 13:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3358423.LUpCnhhR32@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).