DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
	thomas@monjalon.net, Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] app/testpmd: dump private info in 'show port info'
Date: Wed, 15 Mar 2023 10:12:48 +0000	[thread overview]
Message-ID: <33a601b7-8e44-6dc7-923a-27d9a74c6993@amd.com> (raw)
In-Reply-To: <20230315023328.35980-1-fengchengwen@huawei.com>

On 3/15/2023 2:33 AM, Chengwen Feng wrote:
> This patch adds dump private info in 'show port info [port_id]' cmd.
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>  app/test-pmd/config.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 018536f177..ab5199f223 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -938,6 +938,11 @@ port_infos_display(portid_t port_id)
>  		printf("unknown\n");
>  		break;
>  	}
> +	printf("Device private info:\n");

Not all drivers support device private info, above should print only
when it is supported.

> +	ret = rte_eth_dev_priv_dump(port_id, stdout);
> +	if (ret < 0)
> +		fprintf(stderr, "  Failed to dump private info with error (%d): %s\n",
> +			ret, strerror(-ret));

Similarly, if driver doesn't support '.eth_dev_priv_dump' it shouldn't
print the above error log.


  parent reply	other threads:[~2023-03-15 10:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 11:50 [PATCH] app/testpmd: support dump ethdev private cmd Chengwen Feng
2023-03-14 13:45 ` Ferruh Yigit
2023-03-15  2:02   ` fengchengwen
2023-03-15  2:33 ` [PATCH] app/testpmd: dump private info in 'show port info' Chengwen Feng
2023-03-15  8:28   ` Singh, Aman Deep
2023-03-15 10:12   ` Ferruh Yigit [this message]
2023-03-16  1:10     ` fengchengwen
2023-03-16  7:55       ` Thomas Monjalon
2023-03-16  9:39         ` fengchengwen
2023-03-16  9:19       ` Dmitry Kozlyuk
2023-03-16  9:43         ` fengchengwen
2023-03-16 10:46         ` Ferruh Yigit
2023-03-16 15:16           ` Thomas Monjalon
2023-03-16  9:32 ` [PATCH v2] " Chengwen Feng
2023-03-16 11:42   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33a601b7-8e44-6dc7-923a-27d9a74c6993@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=thomas@monjalon.net \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).