DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Guo, Junfeng" <junfeng.guo@intel.com>
Cc: stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"He, Xingguang" <xingguang.he@intel.com>,
	"Laatz, Kevin" <kevin.laatz@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops
Date: Mon, 03 Jul 2023 17:44:15 +0200	[thread overview]
Message-ID: <3426428.QJadu78ljV@thomas> (raw)
In-Reply-To: <MW3PR11MB45872AB58A3228102F1CFDDFE329A@MW3PR11MB4587.namprd11.prod.outlook.com>

03/07/2023 08:53, Wu, Jingjing:
> 
> > -----Original Message-----
> > From: Guo, Junfeng <junfeng.guo@intel.com>
> > Sent: Wednesday, June 28, 2023 5:12 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang <xingguang.he@intel.com>; Laatz, Kevin
> > <kevin.laatz@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>
> > Subject: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops
> > 
> > During EAL cleanup stage, all bus devices are cleaned up properly.
> > In the meantime, the ntb example app will also do the device cleanup
> > process, which may call the dev ops '*dev->dev_ops->dev_close' twice.
> > 
> > If this dev ops for ntb was called twice, the interrupt handle for
> > EAL will be disabled twice and will lead to error for the seconde
> > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx"
> > 
> > Thus, this patch added the check process for disabling interrupt in
> > dev_close ops, to ensure that interrupt only be disabled once.
> > 
> > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied, thanks.




      reply	other threads:[~2023-07-03 15:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14  5:14 [PATCH] examples/ntb: remove redundant logic for dev close Junfeng Guo
2023-06-15  8:28 ` Ling, WeiX
2023-06-28  0:12 ` Thomas Monjalon
2023-06-28  2:19   ` Guo, Junfeng
2023-06-28  2:37     ` Guo, Junfeng
2023-06-28  7:53       ` Thomas Monjalon
2023-06-28  8:08         ` Guo, Junfeng
2023-06-28  9:12 ` [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Junfeng Guo
2023-06-29  8:03   ` Ling, WeiX
2023-07-03  6:53   ` Wu, Jingjing
2023-07-03 15:44     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3426428.QJadu78ljV@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=junfeng.guo@intel.com \
    --cc=kevin.laatz@intel.com \
    --cc=stable@dpdk.org \
    --cc=xingguang.he@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).