From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Chengwen Feng <fengchengwen@huawei.com>, thomas@monjalon.net, ferruh.yigit@xilinx.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/9] ethdev: define retval when xstats is null of get xstats Date: Wed, 4 May 2022 13:32:30 +0300 Message-ID: <37b98022-4923-e53d-bef1-e0fbc768a68d@oktetlabs.ru> (raw) In-Reply-To: <20220428131600.41032-2-fengchengwen@huawei.com> On 4/28/22 16:15, Chengwen Feng wrote: > Currently the value returned when xstats is NULL of rte_eth_xstats_get() > is not specified, some PMDs (eg. hns3/ipn3ke/mvpp2/axgbe) return zero > while others return the required number of elements. > > This patch defines that the return value should be the required number of > elements when xstats is NULL of rte_eth_xstats_get(). > > Fixes: ce757f5c9a4d ("ethdev: new method to retrieve extended statistics") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> > --- > lib/ethdev/rte_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 04cff8ee10..0b18297c95 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3174,7 +3174,7 @@ int rte_eth_xstats_get_names(uint16_t port_id, > * @param xstats > * A pointer to a table of structure of type *rte_eth_xstat* > * to be filled with device statistics ids and values. > - * This parameter can be set to NULL if n is 0. > + * If set to NULL, the function returns the required number of elements. I'm sorry, but I disagree with the patch. First of all it removes limitation when xstats may be NULL. Second, I think that clarification is not required since: if xstats is NULL, n must be 0 as defined above and return value description says: 3183 * - A positive value higher than n: error, the given statistics table 3184 * is too small. The return value corresponds to the size that should 3185 * be given to succeed. The entries in the table are not valid and 3186 * shall not be used by the caller. > * @param n > * The size of the xstats array (number of elements). > * @return
next prev parent reply other threads:[~2022-05-04 10:32 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-16 1:07 [PATCH 0/3] bugfix for ethdev telemetry Chengwen Feng 2022-04-16 1:07 ` [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs Chengwen Feng 2022-04-16 1:38 ` Stephen Hemminger 2022-04-21 6:49 ` Andrew Rybchenko 2022-04-24 3:44 ` fengchengwen 2022-04-25 10:16 ` Morten Brørup 2022-04-28 13:38 ` fengchengwen 2022-04-28 13:53 ` Morten Brørup 2022-04-16 1:07 ` [PATCH 2/3] ethdev: fix memory leak when telemetry xstats Chengwen Feng 2022-04-21 6:51 ` Andrew Rybchenko 2022-04-21 8:09 ` David Marchand 2022-04-21 9:03 ` Bruce Richardson 2022-04-22 8:14 ` David Marchand 2022-04-16 1:07 ` [PATCH 3/3] net/cnxk: fix telemetry possible null pointer access Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 0/9] bugfix for ethdev telemetry Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 1/9] ethdev: define retval when xstats is null of get xstats Chengwen Feng 2022-05-04 10:32 ` Andrew Rybchenko [this message] 2022-04-28 13:15 ` [PATCH v2 2/9] net/hns3: adjust " Chengwen Feng 2022-05-06 7:56 ` Min Hu (Connor) 2022-04-28 13:15 ` [PATCH v2 3/9] net/ipn3ke: " Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 4/9] net/mvpp2: " Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 5/9] net/axgbe: " Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 6/9] ethdev: fix memory leak when telemetry xstats Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 7/9] ethdev: support auto-filled flag when telemetry stats Chengwen Feng 2022-04-28 13:15 ` [PATCH v2 8/9] ethdev: fix possible null pointer access Chengwen Feng 2022-04-28 13:16 ` [PATCH v2 9/9] net/cnxk: fix telemetry " Chengwen Feng 2022-05-05 8:02 ` [PATCH v3 00/10] bugfix for ethdev telemetry Chengwen Feng 2022-05-05 8:02 ` [PATCH v3 01/10] ethdev: define retval when xstats is null of get xstats Chengwen Feng 2022-05-05 8:02 ` [PATCH v3 02/10] ethdev: optimize xstats-get API's implementation Chengwen Feng 2022-05-12 10:31 ` Andrew Rybchenko 2022-05-05 8:02 ` [PATCH v3 03/10] net/hns3: adjust retval when xstats is null of get xstats Chengwen Feng 2022-05-12 9:51 ` Andrew Rybchenko 2022-05-05 8:02 ` [PATCH v3 04/10] net/ipn3ke: " Chengwen Feng 2022-05-05 8:02 ` [PATCH v3 05/10] net/mvpp2: " Chengwen Feng 2022-05-05 8:02 ` [PATCH v3 06/10] net/axgbe: " Chengwen Feng 2022-05-12 10:00 ` Andrew Rybchenko 2022-05-05 8:02 ` [PATCH v3 07/10] ethdev: fix memory leak when telemetry xstats Chengwen Feng 2022-05-05 8:02 ` [PATCH v3 08/10] ethdev: support auto-filled flag when telemetry stats Chengwen Feng 2022-05-12 10:26 ` Andrew Rybchenko 2022-05-05 8:02 ` [PATCH v3 09/10] ethdev: fix possible null pointer access Chengwen Feng 2022-05-12 10:29 ` Andrew Rybchenko 2022-05-05 8:02 ` [PATCH v3 10/10] net/cnxk: fix telemetry " Chengwen Feng 2022-05-12 10:30 ` Andrew Rybchenko 2022-05-13 2:53 ` [PATCH v4 0/9] bugfix for ethdev telemetry Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 1/9] ethdev: specify return value of xstats-get API Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 2/9] ethdev: optimize xstats-get API's implementation Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 3/9] net/hns3: adjust return value of xstats-get ops Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 4/9] net/ipn3ke: " Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 5/9] net/mvpp2: " Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 6/9] net/axgbe: " Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 7/9] ethdev: fix memory leak when telemetry xstats Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 8/9] ethdev: fix possible null pointer access Chengwen Feng 2022-05-13 2:53 ` [PATCH v4 9/9] net/cnxk: fix telemetry " Chengwen Feng 2022-05-16 8:43 ` [PATCH v4 0/9] bugfix for ethdev telemetry Morten Brørup 2022-05-20 14:50 ` Andrew Rybchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=37b98022-4923-e53d-bef1-e0fbc768a68d@oktetlabs.ru \ --to=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=fengchengwen@huawei.com \ --cc=ferruh.yigit@xilinx.com \ --cc=kirankumark@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=skori@marvell.com \ --cc=skoteshwar@marvell.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git