From: "Wang, Dong1" <dong1.wang@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone
Date: Wed, 14 Nov 2018 11:33:45 +0000 [thread overview]
Message-ID: <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com>
Acked-by: Wang Dong <dong1.wang@intel.com>
-----Original Message-----
From: Ananyev, Konstantin
Sent: Tuesday, November 13, 2018 19:52
To: Lipiec, Herakliusz <herakliusz.lipiec@intel.com>; dev@dpdk.org
Cc: Wang, Dong1 <dong1.wang@intel.com>; thomas@monjalon.net; Burakov, Anatoly <anatoly.burakov@intel.com>; stable@dpdk.org
Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when using clone
> -----Original Message-----
> From: Lipiec, Herakliusz
> Sent: Tuesday, November 13, 2018 11:49 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wang, Dong1
> <dong1.wang@intel.com>; thomas@monjalon.net; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Lipiec, Herakliusz
> <herakliusz.lipiec@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using
> clone
>
> The ipv4_multicast sample application was dropping packets when using
> mbuf clone. When creating an L2 header and copying metadata from the
> source packet, the ol_flags were also copied along with all the other
> metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in
> its ol_flags, this caused the packets to never be freed when using
> rte_pktmbuf_free.
> Since copying ol_flags from the cloned packet is not necessary in the
> first place, just don't do it.
>
> Fixes: af75078fece3 ("first public release")
> CC: stable@dpdk.org
>
> Reported-by: Wang Dong <dong1.wang@intel.com>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2018-11-14 11:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 20:46 [dpdk-dev] [PATCH] " Herakliusz Lipiec
2018-11-12 22:44 ` Ananyev, Konstantin
2018-11-13 9:25 ` Thomas Monjalon
2018-11-13 9:47 ` Ananyev, Konstantin
2018-11-13 10:21 ` Burakov, Anatoly
2018-11-13 10:28 ` Ananyev, Konstantin
2018-11-13 11:49 ` [dpdk-dev] [PATCH v2] " Herakliusz Lipiec
2018-11-13 11:51 ` Ananyev, Konstantin
2018-11-14 11:33 ` Wang, Dong1 [this message]
2018-11-18 21:56 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-14 2:28 ` [dpdk-dev] " Wang, Dong1
2018-11-14 9:02 ` Ananyev, Konstantin
2018-11-14 10:09 ` Wang, Dong1
2018-11-14 10:17 ` Ananyev, Konstantin
2018-11-14 11:06 ` Wang, Dong1
2018-11-14 11:19 ` Ananyev, Konstantin
2018-11-14 11:32 ` Wang, Dong1
2018-11-20 5:40 ` Zhao1, Wei
2018-11-20 9:52 ` Ananyev, Konstantin
2018-11-14 10:21 ` Lipiec, Herakliusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com \
--to=dong1.wang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).