* [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement
@ 2019-07-25 21:31 Michael Santana
2019-07-26 7:09 ` David Marchand
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael Santana @ 2019-07-25 21:31 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, Michael Santana Francisco
This patch reduces the memory footprint of tables for the unit test.
Lower memory footprint means the test now passes when trying to allocate
the tables.
Signed-off-by: Michael Santana <msantana@redhat.com>
---
app/test/test_table_tables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_table_tables.c b/app/test/test_table_tables.c
index 20df2e922..21c4086c2 100644
--- a/app/test/test_table_tables.c
+++ b/app/test/test_table_tables.c
@@ -464,7 +464,7 @@ test_table_lpm_ipv6(void)
struct rte_table_lpm_ipv6_params lpm_params = {
.name = "LPM",
.n_rules = 1 << 24,
- .number_tbl8s = 1 << 21,
+ .number_tbl8s = 1 << 18,
.entry_unique_size = entry_size,
.offset = APP_METADATA_OFFSET(32)
};
@@ -492,7 +492,7 @@ test_table_lpm_ipv6(void)
if (table != NULL)
return -4;
- lpm_params.number_tbl8s = 1 << 21;
+ lpm_params.number_tbl8s = 1 << 18;
lpm_params.entry_unique_size = 0;
table = rte_table_lpm_ipv6_ops.f_create(&lpm_params, 0, entry_size);
if (table != NULL)
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement
2019-07-25 21:31 [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement Michael Santana
@ 2019-07-26 7:09 ` David Marchand
2019-07-26 15:04 ` Michael Santana Francisco
2019-07-26 9:35 ` Dumitrescu, Cristian
2019-07-29 15:18 ` [dpdk-dev] [PATCH v2] " Michael Santana
2 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2019-07-26 7:09 UTC (permalink / raw)
To: Michael Santana; +Cc: dev, Cristian Dumitrescu
Hello Michael,
On Thu, Jul 25, 2019 at 11:31 PM Michael Santana <msantana@redhat.com> wrote:
>
> This patch reduces the memory footprint of tables for the unit test.
> Lower memory footprint means the test now passes when trying to allocate
> the tables.
This is mainly for tests in CI, might be worth mentionning in the commitlog.
Do you have a rough estimate of how the need in memory changes with this patch?
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement
2019-07-25 21:31 [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement Michael Santana
2019-07-26 7:09 ` David Marchand
@ 2019-07-26 9:35 ` Dumitrescu, Cristian
2019-07-29 15:18 ` [dpdk-dev] [PATCH v2] " Michael Santana
2 siblings, 0 replies; 6+ messages in thread
From: Dumitrescu, Cristian @ 2019-07-26 9:35 UTC (permalink / raw)
To: Michael Santana, dev
> -----Original Message-----
> From: Michael Santana [mailto:msantana@redhat.com]
> Sent: Thursday, July 25, 2019 10:32 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Michael Santana
> Francisco <msantana@redhat.com>
> Subject: [PATCH] test/table_autotest: Decrease memory requirement
>
> This patch reduces the memory footprint of tables for the unit test.
> Lower memory footprint means the test now passes when trying to allocate
> the tables.
>
> Signed-off-by: Michael Santana <msantana@redhat.com>
> ---
> app/test/test_table_tables.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement
2019-07-26 7:09 ` David Marchand
@ 2019-07-26 15:04 ` Michael Santana Francisco
0 siblings, 0 replies; 6+ messages in thread
From: Michael Santana Francisco @ 2019-07-26 15:04 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Cristian Dumitrescu
On 7/26/19 3:09 AM, David Marchand wrote:
> Hello Michael,
>
> On Thu, Jul 25, 2019 at 11:31 PM Michael Santana <msantana@redhat.com> wrote:
>> This patch reduces the memory footprint of tables for the unit test.
>> Lower memory footprint means the test now passes when trying to allocate
>> the tables.
> This is mainly for tests in CI, might be worth mentionning in the commitlog.
will update
>
> Do you have a rough estimate of how the need in memory changes with this patch?
Based on the equation on lib/librte_lpm/rte_lpm6.c:317, that particular
allocation went from 2.2GB to ~300MB
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] test/table_autotest: Decrease memory requirement
2019-07-25 21:31 [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement Michael Santana
2019-07-26 7:09 ` David Marchand
2019-07-26 9:35 ` Dumitrescu, Cristian
@ 2019-07-29 15:18 ` Michael Santana
2019-07-30 9:27 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Michael Santana @ 2019-07-29 15:18 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, Michael Santana Francisco
This patch reduces the memory footprint of tables for the unit test.
Lower memory footprint means the test now passes when trying to allocate
the tables. This patch is mainly to make table_autotest pass in CI.
Signed-off-by: Michael Santana <msantana@redhat.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
app/test/test_table_tables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_table_tables.c b/app/test/test_table_tables.c
index 20df2e922..21c4086c2 100644
--- a/app/test/test_table_tables.c
+++ b/app/test/test_table_tables.c
@@ -464,7 +464,7 @@ test_table_lpm_ipv6(void)
struct rte_table_lpm_ipv6_params lpm_params = {
.name = "LPM",
.n_rules = 1 << 24,
- .number_tbl8s = 1 << 21,
+ .number_tbl8s = 1 << 18,
.entry_unique_size = entry_size,
.offset = APP_METADATA_OFFSET(32)
};
@@ -492,7 +492,7 @@ test_table_lpm_ipv6(void)
if (table != NULL)
return -4;
- lpm_params.number_tbl8s = 1 << 21;
+ lpm_params.number_tbl8s = 1 << 18;
lpm_params.entry_unique_size = 0;
table = rte_table_lpm_ipv6_ops.f_create(&lpm_params, 0, entry_size);
if (table != NULL)
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] test/table_autotest: Decrease memory requirement
2019-07-29 15:18 ` [dpdk-dev] [PATCH v2] " Michael Santana
@ 2019-07-30 9:27 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-07-30 9:27 UTC (permalink / raw)
To: Michael Santana; +Cc: dev, cristian.dumitrescu
29/07/2019 17:18, Michael Santana:
> This patch reduces the memory footprint of tables for the unit test.
> Lower memory footprint means the test now passes when trying to allocate
> the tables. This patch is mainly to make table_autotest pass in CI.
>
> Signed-off-by: Michael Santana <msantana@redhat.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-30 9:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 21:31 [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement Michael Santana
2019-07-26 7:09 ` David Marchand
2019-07-26 15:04 ` Michael Santana Francisco
2019-07-26 9:35 ` Dumitrescu, Cristian
2019-07-29 15:18 ` [dpdk-dev] [PATCH v2] " Michael Santana
2019-07-30 9:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).