* [dpdk-dev] [PATCH] net/igb: add i210 flashless device ids
@ 2017-08-21 11:47 Markus Theil
2017-10-03 18:53 ` Ferruh Yigit
2017-10-03 18:56 ` Ferruh Yigit
0 siblings, 2 replies; 3+ messages in thread
From: Markus Theil @ 2017-08-21 11:47 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, Markus Theil
This patch adds two missing device IDs for Intel i210 chips in flashless
mode. Copper flashless mode was tested on a PC Engines APU2C4 board.
Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
---
drivers/net/e1000/igb_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index e4f7a9f..cf1fdbe 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -334,6 +334,8 @@ static const struct rte_pci_id pci_id_igb_map[] = {
{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_FIBER) },
{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_SERDES) },
{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_SGMII) },
+ { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_COPPER_FLASHLESS) },
+ { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_SERDES_FLASHLESS) },
{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I211_COPPER) },
{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I354_BACKPLANE_1GBPS) },
{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I354_SGMII) },
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/igb: add i210 flashless device ids
2017-08-21 11:47 [dpdk-dev] [PATCH] net/igb: add i210 flashless device ids Markus Theil
@ 2017-10-03 18:53 ` Ferruh Yigit
2017-10-03 18:56 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-03 18:53 UTC (permalink / raw)
To: Markus Theil, wenzhuo.lu; +Cc: dev
On 8/21/2017 12:47 PM, Markus Theil wrote:
> This patch adds two missing device IDs for Intel i210 chips in flashless
> mode. Copper flashless mode was tested on a PC Engines APU2C4 board.
There is no comment on this patch.
Adding new device support looks harmless, at worst we can remove them
back, so I will get this.
But that would be very helpful if anybody having these devices tests them.
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> ---
> drivers/net/e1000/igb_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index e4f7a9f..cf1fdbe 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -334,6 +334,8 @@ static const struct rte_pci_id pci_id_igb_map[] = {
> { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_FIBER) },
> { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_SERDES) },
> { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_SGMII) },
> + { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_COPPER_FLASHLESS) },
> + { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I210_SERDES_FLASHLESS) },
> { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I211_COPPER) },
> { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I354_BACKPLANE_1GBPS) },
> { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_I354_SGMII) },
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/igb: add i210 flashless device ids
2017-08-21 11:47 [dpdk-dev] [PATCH] net/igb: add i210 flashless device ids Markus Theil
2017-10-03 18:53 ` Ferruh Yigit
@ 2017-10-03 18:56 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-03 18:56 UTC (permalink / raw)
To: Markus Theil, wenzhuo.lu; +Cc: dev
On 8/21/2017 12:47 PM, Markus Theil wrote:
> This patch adds two missing device IDs for Intel i210 chips in flashless
> mode. Copper flashless mode was tested on a PC Engines APU2C4 board.
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-03 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-21 11:47 [dpdk-dev] [PATCH] net/igb: add i210 flashless device ids Markus Theil
2017-10-03 18:53 ` Ferruh Yigit
2017-10-03 18:56 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).