From: "Menon, Ranjit" <ranjit.menon@intel.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>, <thomas@monjalon.net>, <talshn@nvidia.com>,
<dmitry.kozliuk@gmail.com>, <Narcisa.Vasile@microsoft.com>,
<Vipin.Varghese@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix unknown NUMA node value on Windows
Date: Mon, 27 Sep 2021 11:29:44 -0700 [thread overview]
Message-ID: <443fbd7d-6f00-c0cd-df84-781ad47b89ca@intel.com> (raw)
In-Reply-To: <20210927184322.1455-1-pallavi.kadam@intel.com>
On 9/27/2021 11:43 AM, Pallavi Kadam wrote:
> Based on the rte_eth_dev_socket_id() documentation,
> set the default numa_node to -1. When the API is unsuccessful,
> set numa_node to 0.
> This change more correctly resembles the Linux code.
>
> Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows")
> Cc: stable@dpdk.org
>
> Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
> drivers/bus/pci/windows/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index 343ef6f33b..644c452c76 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info,
> }
>
> /* Get NUMA node using DEVPKEY_Device_Numa_Node */
> + dev->device.numa_node = SOCKET_ID_ANY;
> res = SetupDiGetDevicePropertyW(dev_info, dev_info_data,
> &DEVPKEY_Device_Numa_Node, &property_type,
> (BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
> @@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info,
> DWORD error = GetLastError();
> if (error == ERROR_NOT_FOUND) {
> /* On older CPUs, NUMA is not bound to PCIe locality. */
> - dev->device.numa_node = SOCKET_ID_ANY;
> + dev->device.numa_node = 0;
> return ERROR_SUCCESS;
> }
> RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
Acked-by: Ranjit Menon <ranjit.menon@intel.com
<mailto:ranjit.menon@intel.com>>
next prev parent reply other threads:[~2021-09-27 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 18:43 Pallavi Kadam
2021-09-27 18:29 ` Menon, Ranjit [this message]
2021-09-27 18:34 ` Menon, Ranjit
2021-09-30 16:22 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443fbd7d-6f00-c0cd-df84-781ad47b89ca@intel.com \
--to=ranjit.menon@intel.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=Vipin.Varghese@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).