DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] devtools: forbid experimental build flag for non-examples
@ 2020-07-16  7:26 David Marchand
  2020-07-30 21:47 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2020-07-16  7:26 UTC (permalink / raw)
  To: dev; +Cc: Thomas Monjalon

-DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5

Warn people not to copy/paste this flag that was needed before.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 devtools/checkpatches.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 58021aa5dd..82d57b565b 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -77,6 +77,14 @@ check_forbidden_additions() { # <patch>
 		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
 		"$1" || res=1
 
+	# forbid use of experimental build flag unneeded in non-examples
+	awk -v FOLDERS='app lib drivers' \
+		-v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API allow_experimental_apis' \
+		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using experimental build flag for in-tree compilation' \
+		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+		"$1" || res=1
+
 	# svg figures must be included with wildcard extension
 	# because of png conversion for pdf docs
 	awk -v FOLDERS='doc' \
-- 
2.23.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: forbid experimental build flag for non-examples
  2020-07-16  7:26 [dpdk-dev] [PATCH] devtools: forbid experimental build flag for non-examples David Marchand
@ 2020-07-30 21:47 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-07-30 21:47 UTC (permalink / raw)
  To: David Marchand; +Cc: dev

16/07/2020 09:26, David Marchand:
> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
> https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5
> 
> Warn people not to copy/paste this flag that was needed before.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied with small rewording, thanks




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16  7:26 [dpdk-dev] [PATCH] devtools: forbid experimental build flag for non-examples David Marchand
2020-07-30 21:47 ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox