From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbo.xia@intel.com, patrick.fu@intel.com,
amorenoz@redhat.com, shahafs@mellanox.com,
viacheslavo@nvidia.com, matan@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v2 1/8] bus/vdev: add DMA mapping ops
Date: Mon, 29 Mar 2021 23:59:45 +0200 [thread overview]
Message-ID: <5162509.OuVXpe82kn@thomas> (raw)
In-Reply-To: <20200925123113.68916-2-maxime.coquelin@redhat.com>
25/09/2020 14:31, Maxime Coquelin:
> Add DMA map/unmap operation callbacks to the vdev bus, which
> could be used by DMA capable vdev drivers.
[...]
> @@ -551,6 +601,8 @@ static struct rte_bus rte_vdev_bus = {
> .plug = vdev_plug,
> .unplug = vdev_unplug,
> .parse = vdev_parse,
> + .dma_map = vdev_dma_map,
> + .dma_unmap = vdev_dma_unmap,
> .dev_iterate = rte_vdev_dev_iterate,
> };
The functions map/unmap look to be the same as in PCI bus driver.
I wonder whether it would make sense to move these operations
at rte_driver level?
It seems we don't need anything specific to PCI or vdev,
but just being able to get some class driver private data, right?
next prev parent reply other threads:[~2021-03-29 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 12:31 [dpdk-dev] [PATCH v2 0/8] virtio-user: introduce vhost-vdpa backend Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 1/8] bus/vdev: add DMA mapping ops Maxime Coquelin
2021-03-29 21:59 ` Thomas Monjalon [this message]
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 2/8] net/virtio: introduce DMA ops Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 3/8] net/virtio: move backend type selection to ethdev Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 4/8] net/virtio: introduce Vhost-vDPA backend type Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 5/8] net/virtio: check protocol feature in user backend Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 6/8] net/virtio: adapt Virtio-user status size Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 7/8] net/virtio: split virtio-user start Maxime Coquelin
2020-09-25 12:31 ` [dpdk-dev] [PATCH v2 8/8] net/virtio: introduce Vhost-vDPA backend Maxime Coquelin
2020-09-29 8:31 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5162509.OuVXpe82kn@thomas \
--to=thomas@monjalon.net \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).