Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/21/2019 7:52 PM, Rasesh Mody wrote:
> Hi Kevin,
> 
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Monday, October 21, 2019 3:58 AM
>>
>> ----------------------------------------------------------------------
>> On 20/10/2019 06:20, Rasesh Mody wrote:
>>> In our testing we have identified a critical FW bug. Performance is
>>> degraded significantly for certain packet sizes with 8.40.25.0 FW.
>>>
>>> This patch updates the FW to version 8.40.33.0. The updated FW has a
>>> fix to performance issue.
>>>
>>> The patch also adds initialization for FW overlay RAM as part of
>>> hardware initialization which is required by the new FW.
>>>
>>> Fixes: 066f0d380a2f ("net/qede/base: update FW to 8.40.25.0")
>>>
>>
>> Hi Rasesh, it should be:
>>
>> Fixes: 21c959e2cb10 ("net/qede/base: update FW to 8.40.25.0")
>>
> 
> I could not find the 21c959e2cb10 reference, can you please let me know which tree is it coming from?

Hi Kevin,

For similar case, if the fixed commit has been pulled by main tree, I am
updating the fixes tag on the next-net,
if not pulled yet, mostly I am squashing the fix to the original commit in
next-net, if I can't squash for some reason Thomas is fixing the tag while
merging into the main tree. (Our check-git-log commit detected wrong Fixes tag
already.)

So if you pick fixes from main tree only, the fixes tags will be always correct.
If you pick commits from sub-trees, fixes tag won't be only problem, the commits
also will be not fully tested...

> 
>>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>>> ---
>>>  doc/guides/nics/qede.rst                      |   4 +-
>>>  drivers/net/qede/base/common_hsi.h            |   6 +-
>>>  drivers/net/qede/base/ecore.h                 |   4 +-
>>>  drivers/net/qede/base/ecore_dev.c             |  19 ++-
>>>  drivers/net/qede/base/ecore_hsi_debug_tools.h |   3 +
>>>  drivers/net/qede/base/ecore_hw.c              |   4 +-
>>>  drivers/net/qede/base/ecore_init_fw_funcs.c   | 138
>> ++++++++++++++++++
>>>  drivers/net/qede/base/ecore_init_fw_funcs.h   |  35 +++++
>>>  drivers/net/qede/base/ecore_int.c             |  14 +-
>>>  drivers/net/qede/base/ecore_iro_values.h      | 122 ++++++++--------
>>>  drivers/net/qede/qede_ethdev.h                |   2 +-
>>>  drivers/net/qede/qede_main.c                  |   2 +-
>>>  12 files changed, 274 insertions(+), 79 deletions(-)
>>>
>>> diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index
>>> 471d98014..2f4045795 100644
>>> --- a/doc/guides/nics/qede.rst
>>> +++ b/doc/guides/nics/qede.rst
>>> @@ -78,9 +78,9 @@ Supported QLogic Adapters  Prerequisites
>>>  -------------
>>>
>>> -- Requires storm firmware version **8.37.7.0**. Firmware may be
>>> available
>>> +- Requires storm firmware version **8.40.33.0**. Firmware may be
>>> +available
>>>    inbox in certain newer Linux distros under the standard directory
>>> -  ``E.g. /lib/firmware/qed/qed_init_values-8.37.7.0.bin``.
>>> +  ``E.g. /lib/firmware/qed/qed_init_values-8.40.33.0.bin``.
>>
>> Not available in latest Fedora and Ubuntu releases
> 
> That is right, it would take some time before its available in latest Fedora/Ubuntu releases.
>>
>>>    If the required firmware files are not available then download it from
>>>    `linux-firmware git repository
>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__git.kernel.org_pu
>>> b_scm_linux_kernel_git_firmware_linux-
>> 2Dfirmware.git_tree_qed&d=DwIFaQ
>>>
>> &c=nKjWec2b6R0mOyPaz7xtfQ&r=9aB46H7c7TYTnBun6ODgtnNLQdw3jNiVKH
>> bs9eOyBS
>>>
>> U&m=LjD8kHeZxFHw1ql6Jz5s_XJfxPOIaBqLpyP5FDBNHQc&s=YOhhxcxca9mX
>> dFNN7HjG
>>> djQF5G22nnsfj1fy4S4cOCM&e= >`_
>>
>> Not available here either
> 
> We are working on getting 8.40.33.0 version into linux-firmware git tree.
> 
> Thanks!
> -Rasesh
>>
>>>    or `QLogic Driver Download Center
>> <http://driverdownloads.qlogic.com/QLogicDriverDownloads_UI/DefaultNew
>> Search.aspx>`_.
>>
>> Maybe here? 8.37 is the latest elsewhere.
>