Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug

[Kevin Traynor <ktraynor@redhat.com>]

On 21/10/2019 21:46, Rasesh Mody wrote:
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Monday, October 21, 2019 1:10 PM
>>
>> ----------------------------------------------------------------------
>> On 21/10/2019 19:52, Rasesh Mody wrote:
>>> Hi Kevin,
>>>
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Monday, October 21, 2019 3:58 AM
>>>>
>>>> ---------------------------------------------------------------------
>>>> - On 20/10/2019 06:20, Rasesh Mody wrote:
>>>>> In our testing we have identified a critical FW bug. Performance is
>>>>> degraded significantly for certain packet sizes with 8.40.25.0 FW.
>>>>>
>>>>> This patch updates the FW to version 8.40.33.0. The updated FW has a
>>>>> fix to performance issue.
>>>>>
>>>>> The patch also adds initialization for FW overlay RAM as part of
>>>>> hardware initialization which is required by the new FW.
>>>>>
>>>>> Fixes: 066f0d380a2f ("net/qede/base: update FW to 8.40.25.0")
>>>>>
>>>> Hi Rasesh, it should be:
>>>>
>>>> Fixes: 21c959e2cb10 ("net/qede/base: update FW to 8.40.25.0")
>>>>
>>> I could not find the 21c959e2cb10 reference, can you please let me know
>> which tree is it coming from?
>> dpdk-next-net and dpdk-next-net-brcm trees. The commit doesn't seem to
>> be in dpdk tree yet.
> dpdk-next-net tree gives a different reference as below. 
> Fixes: 0cd01921343e ("net/qede/base: update FW to 8.40.25.0")
> 

ah ok, I figured out it is a problem on my side - got back in sync with
the remote and I see the same commit-id. Sorry for the noise.

> The one, originally used, is from dpdk-next-net-mrvl tree.
> 
> Do you suggest to update the Fixes tag to a commit id from dpdk-next-net tree?
> 

The best would be the dpdk tree, but you can't do that as it's not there
yet. I'd probably go with the highest tree that it has been merged into
(dpdk-next-net) but i'm not sure it really matters. From a stable view,
we won't find the sha1 in the dpdk tree, but we'd see that there's no
stable tag and we'd find the commit through the title.