From: Dekel Peled <dekelp@mellanox.com> To: john.mcnamara@intel.com, marko.kovacevic@intel.com, nhorman@tuxdriver.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, anatoly.burakov@intel.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, matan@mellanox.com, shahafs@mellanox.com, viacheslavo@mellanox.com, rmody@marvell.com, shshaikh@marvell.com, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, yongwang@vmware.com, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, jingjing.wu@intel.com, bernard.iremonger@intel.com Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH v4 3/3] app/testpmd: use API to set max LRO packet size Date: Thu, 7 Nov 2019 14:35:14 +0200 Message-ID: <60880a18e81b7eb4fe10d12fbc27ff9fb91730c5.1573129825.git.dekelp@mellanox.com> (raw) In-Reply-To: <cover.1573129825.git.dekelp@mellanox.com> This patch implements use of the API for LRO aggregated packet max size. It adds command-line and runtime commands to configure this value, and adds option to show the supported value. Documentation is updated accordingly. Signed-off-by: Dekel Peled <dekelp@mellanox.com> --- app/test-pmd/cmdline.c | 73 +++++++++++++++++++++++++++++ app/test-pmd/config.c | 2 + app/test-pmd/parameters.c | 7 +++ app/test-pmd/testpmd.c | 1 + doc/guides/testpmd_app_ug/run_app.rst | 5 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++++ 6 files changed, 97 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 49c45a3..62bbc81 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2037,6 +2037,78 @@ struct cmd_config_max_pkt_len_result { }, }; +/* *** config max LRO aggregated packet size *** */ +struct cmd_config_max_lro_pkt_size_result { + cmdline_fixed_string_t port; + cmdline_fixed_string_t keyword; + cmdline_fixed_string_t all; + cmdline_fixed_string_t name; + uint32_t value; +}; + +static void +cmd_config_max_lro_pkt_size_parsed(void *parsed_result, + __attribute__((unused)) struct cmdline *cl, + __attribute__((unused)) void *data) +{ + struct cmd_config_max_lro_pkt_size_result *res = parsed_result; + portid_t pid; + + if (!all_ports_stopped()) { + printf("Please stop all ports first\n"); + return; + } + + RTE_ETH_FOREACH_DEV(pid) { + struct rte_port *port = &ports[pid]; + + if (!strcmp(res->name, "max-lro-pkt-size")) { + if (res->value == + port->dev_conf.rxmode.max_lro_pkt_size) + return; + + port->dev_conf.rxmode.max_lro_pkt_size = res->value; + } else { + printf("Unknown parameter\n"); + return; + } + } + + init_port_config(); + + cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); +} + +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_port = + TOKEN_STRING_INITIALIZER(struct cmd_config_max_lro_pkt_size_result, + port, "port"); +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_keyword = + TOKEN_STRING_INITIALIZER(struct cmd_config_max_lro_pkt_size_result, + keyword, "config"); +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_all = + TOKEN_STRING_INITIALIZER(struct cmd_config_max_lro_pkt_size_result, + all, "all"); +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_name = + TOKEN_STRING_INITIALIZER(struct cmd_config_max_lro_pkt_size_result, + name, "max-lro-pkt-size"); +cmdline_parse_token_num_t cmd_config_max_lro_pkt_size_value = + TOKEN_NUM_INITIALIZER(struct cmd_config_max_lro_pkt_size_result, + value, UINT32); + +cmdline_parse_inst_t cmd_config_max_lro_pkt_size = { + .f = cmd_config_max_lro_pkt_size_parsed, + .data = NULL, + .help_str = "port config all max-lro-pkt-size <value>", + .tokens = { + (void *)&cmd_config_max_lro_pkt_size_port, + (void *)&cmd_config_max_lro_pkt_size_keyword, + (void *)&cmd_config_max_lro_pkt_size_all, + (void *)&cmd_config_max_lro_pkt_size_name, + (void *)&cmd_config_max_lro_pkt_size_value, + NULL, + }, +}; + /* *** configure port MTU *** */ struct cmd_config_mtu_result { cmdline_fixed_string_t port; @@ -19025,6 +19097,7 @@ struct cmd_show_port_supported_ptypes_result { (cmdline_parse_inst_t *)&cmd_config_rx_tx, (cmdline_parse_inst_t *)&cmd_config_mtu, (cmdline_parse_inst_t *)&cmd_config_max_pkt_len, + (cmdline_parse_inst_t *)&cmd_config_max_lro_pkt_size, (cmdline_parse_inst_t *)&cmd_config_rx_mode_flag, (cmdline_parse_inst_t *)&cmd_config_rss, (cmdline_parse_inst_t *)&cmd_config_rxtx_ring_size, diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b603974..e1e5cf7 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -616,6 +616,8 @@ static int bus_match_all(const struct rte_bus *bus, const void *data) printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize); printf("Maximum configurable length of RX packet: %u\n", dev_info.max_rx_pktlen); + printf("Maximum configurable size of LRO aggregated packet: %u\n", + dev_info.max_lro_pkt_size); if (dev_info.max_vfs) printf("Maximum number of VFs: %u\n", dev_info.max_vfs); if (dev_info.max_vmdq_pools) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 9ea87c1..eda395b 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -107,6 +107,8 @@ printf(" --total-num-mbufs=N: set the number of mbufs to be allocated " "in mbuf pools.\n"); printf(" --max-pkt-len=N: set the maximum size of packet to N bytes.\n"); + printf(" --max-lro-pkt-size=N: set the maximum LRO aggregated packet " + "size to N bytes.\n"); #ifdef RTE_LIBRTE_CMDLINE printf(" --eth-peers-configfile=name: config file with ethernet addresses " "of peer ports.\n"); @@ -592,6 +594,7 @@ { "mbuf-size", 1, 0, 0 }, { "total-num-mbufs", 1, 0, 0 }, { "max-pkt-len", 1, 0, 0 }, + { "max-lro-pkt-size", 1, 0, 0 }, { "pkt-filter-mode", 1, 0, 0 }, { "pkt-filter-report-hash", 1, 0, 0 }, { "pkt-filter-size", 1, 0, 0 }, @@ -888,6 +891,10 @@ "Invalid max-pkt-len=%d - should be > %d\n", n, RTE_ETHER_MIN_LEN); } + if (!strcmp(lgopts[opt_idx].name, "max-lro-pkt-size")) { + n = atoi(optarg); + rx_mode.max_lro_pkt_size = (uint32_t) n; + } if (!strcmp(lgopts[opt_idx].name, "pkt-filter-mode")) { if (!strcmp(optarg, "signature")) fdir_conf.mode = diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5ba9741..3fe694f 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -419,6 +419,7 @@ struct fwd_engine * fwd_engines[] = { struct rte_eth_rxmode rx_mode = { .max_rx_pkt_len = RTE_ETHER_MAX_LEN, /**< Default maximum frame length. */ + .max_lro_pkt_size = RTE_ETHER_MAX_LEN, }; struct rte_eth_txmode tx_mode = { diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 00e0c2a..721f740 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -112,6 +112,11 @@ The command line options are: Set the maximum packet size to N bytes, where N >= 64. The default value is 1518. +* ``--max-lro-pkt-size=N`` + + Set the maximum LRO aggregated packet size to N bytes, where N >= 64. + The default value is 1518. + * ``--eth-peers-configfile=name`` Use a configuration file containing the Ethernet addresses of the peer ports. diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index c68a742..0267295 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -2139,6 +2139,15 @@ Set the maximum packet length:: This is equivalent to the ``--max-pkt-len`` command-line option. +port config - max-lro-pkt-size +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Set the maximum LRO aggregated packet size:: + + testpmd> port config all max-lro-pkt-size (value) + +This is equivalent to the ``--max-lro-pkt-size`` command-line option. + port config - Drop Packets ~~~~~~~~~~~~~~~~~~~~~~~~~~ -- 1.8.3.1
next prev parent reply index Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 8:40 [dpdk-dev] [PATCH 0/3] support " Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 1/3] ethdev: " Dekel Peled 2019-11-05 12:39 ` Andrew Rybchenko 2019-11-05 13:09 ` Thomas Monjalon 2019-11-05 14:18 ` Dekel Peled 2019-11-05 14:27 ` Andrew Rybchenko 2019-11-05 14:51 ` Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 2/3] net/mlx5: use " Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 3/3] app/testpmd: " Dekel Peled 2019-11-05 9:35 ` [dpdk-dev] [PATCH 0/3] support " Matan Azrad 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 " Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 1/3] ethdev: " Dekel Peled 2019-11-06 12:26 ` Thomas Monjalon 2019-11-06 12:39 ` Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 2/3] net/mlx5: use " Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: " Dekel Peled 2019-11-06 12:35 ` Iremonger, Bernard 2019-11-06 13:14 ` Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 0/3] support " Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 1/3] ethdev: " Dekel Peled 2019-11-07 11:57 ` [dpdk-dev] [EXT] " Shahed Shaikh 2019-11-07 12:18 ` Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 2/3] net/mlx5: use " Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: " Dekel Peled 2019-11-06 16:41 ` [dpdk-dev] [PATCH v3 0/3] support " Iremonger, Bernard 2019-11-07 6:10 ` Dekel Peled 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 " Dekel Peled 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 1/3] ethdev: " Dekel Peled 2019-11-07 20:15 ` Ferruh Yigit 2019-11-08 6:54 ` Matan Azrad 2019-11-08 9:19 ` Ferruh Yigit 2019-11-08 10:10 ` Matan Azrad 2019-11-08 11:37 ` Ferruh Yigit 2019-11-08 11:56 ` Matan Azrad 2019-11-08 12:51 ` Ferruh Yigit 2019-11-08 16:11 ` Dekel Peled 2019-11-08 16:53 ` Ferruh Yigit 2019-11-09 18:20 ` Matan Azrad 2019-11-10 23:40 ` Ananyev, Konstantin 2019-11-11 8:01 ` Matan Azrad 2019-11-12 18:31 ` Ananyev, Konstantin 2019-11-11 11:15 ` Ferruh Yigit 2019-11-11 11:33 ` Matan Azrad 2019-11-11 12:21 ` Ferruh Yigit 2019-11-11 13:32 ` Matan Azrad 2019-11-08 13:11 ` Ananyev, Konstantin 2019-11-08 14:10 ` Dekel Peled 2019-11-08 14:52 ` Ananyev, Konstantin 2019-11-08 16:08 ` Dekel Peled 2019-11-08 16:28 ` Ananyev, Konstantin 2019-11-09 18:26 ` Matan Azrad 2019-11-10 22:51 ` Ananyev, Konstantin 2019-11-11 6:53 ` Matan Azrad 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 2/3] net/mlx5: use " Dekel Peled 2019-11-08 9:12 ` Slava Ovsiienko 2019-11-08 9:23 ` Ferruh Yigit 2019-11-07 12:35 ` Dekel Peled [this message] 2019-11-07 14:20 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: " Iremonger, Bernard 2019-11-07 20:25 ` Ferruh Yigit 2019-11-08 6:56 ` Matan Azrad 2019-11-08 13:58 ` Dekel Peled 2019-11-08 6:28 ` [dpdk-dev] [PATCH v4 0/3] support " Matan Azrad 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 " Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 1/3] ethdev: " Dekel Peled 2019-11-10 23:07 ` Ananyev, Konstantin 2019-11-11 7:40 ` Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 2/3] net/mlx5: use " Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: " Dekel Peled 2019-11-10 23:11 ` Ananyev, Konstantin 2019-11-11 7:40 ` Dekel Peled 2019-11-08 23:07 ` [dpdk-dev] [PATCH v6] ethdev: add " Thomas Monjalon 2019-11-10 22:47 ` Ananyev, Konstantin 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 0/3] support API to set " Dekel Peled 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 1/3] ethdev: " Dekel Peled 2019-11-12 0:46 ` Ferruh Yigit 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 2/3] net/mlx5: use " Dekel Peled 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: " Dekel Peled 2019-11-12 0:46 ` Ferruh Yigit 2019-11-12 0:47 ` [dpdk-dev] [PATCH v7 0/3] support " Ferruh Yigit
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=60880a18e81b7eb4fe10d12fbc27ff9fb91730c5.1573129825.git.dekelp@mellanox.com \ --to=dekelp@mellanox.com \ --cc=ajit.khaparde@broadcom.com \ --cc=anatoly.burakov@intel.com \ --cc=arybchenko@solarflare.com \ --cc=bernard.iremonger@intel.com \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jingjing.wu@intel.com \ --cc=john.mcnamara@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=matan@mellanox.com \ --cc=maxime.coquelin@redhat.com \ --cc=nhorman@tuxdriver.com \ --cc=rmody@marvell.com \ --cc=shahafs@mellanox.com \ --cc=shshaikh@marvell.com \ --cc=somnath.kotur@broadcom.com \ --cc=thomas@monjalon.net \ --cc=tiwei.bie@intel.com \ --cc=viacheslavo@mellanox.com \ --cc=wenzhuo.lu@intel.com \ --cc=xuanziyang2@huawei.com \ --cc=yongwang@vmware.com \ --cc=zhihong.wang@intel.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions Archives are clonable: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/ public-inbox